[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …)#24329
Merged
wilsonge merged 11 commits intojoomla:4.0-devfrom Feb 9, 2020
Merged
[4.0] Code cleanup: remove setFieldAttribute('catid', 'action', …)#24329wilsonge merged 11 commits intojoomla:4.0-devfrom
wilsonge merged 11 commits intojoomla:4.0-devfrom
Conversation
Since the introduction of the categoryedit form field in the edit models/views of com_content, com_contact, com_newsfeeds and com_banners (d6673d7), there is no `action` attribute on the `catid` form field and thus no need to set it anymore.
action on catid in com_content, …
Contributor
|
@nhusung Can you fix the conflict please. |
Contributor
|
I have tested this item ✅ successfully on cca35fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24329. |
Contributor
|
There are conflicts again 😕 . |
Author
|
Sorry, I made a mistake during the merge |
de09eac to
83c817f
Compare
Author
|
Now my problem should be fixed, sorry again. However, the first push added some review requests and I couldn‘t find a way to remove these. I hope I‘m not getting on your nerves … |
|
@nhusung thanks for Contributing, no reason for care about nerves :-) |
Contributor
|
I have tested this item ✅ successfully on 28ea0f7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24329. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Since the introduction of the
CategoryEditform field in the edit models/views ofcom_content,com_contact,com_newsfeedsandcom_banners(d6673d7), there is noactionattribute on thecatidform field and thus no need to set it anymore.Testing Instructions
As the changes are pretty small, a code review should be enough. However you can have a look at the category field inside the edit forms of com_content, com_contact, com_newsfeeds and com_banners with users associated to different groups and access levels and privileges.
Expected result
Same as before this pull