Merged
Conversation
Codemirror was locked at a specific version that is now very old. This PR changes the setting in package.json so that it follows semver Codemirror has always been very good at following semver so this should be totally safe. (the update process also updated tinymce at the same time)
Contributor
|
I have tested this item ✅ successfully on 6bfb5d2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27868. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 6bfb5d2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27868. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27868. |
Member
|
@wilsonge @brianteeman I just see some |
Contributor
|
I think that's somehow based on OS or something it seems to change all the time. It's not ideal but it's not the end of the world either |
Contributor
Author
|
Thnks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codemirror was locked at a specific version that is now very old.
This PR changes the setting in package.json so that it follows semver
Codemirror has always been very good at following semver so this should be totally safe.
(the update process also updated tinymce at the same time)