Skip to content

[4.0] Add library support to namespace mapper, other fixes#27479

Merged
wilsonge merged 9 commits intojoomla:4.0-devfrom
SharkyKZ:j4/namespacemap-library
Jan 21, 2020
Merged

[4.0] Add library support to namespace mapper, other fixes#27479
wilsonge merged 9 commits intojoomla:4.0-devfrom
SharkyKZ:j4/namespacemap-library

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

Pull Request for Issue #27459.

Summary of Changes

Refactors JNamespacePsr4Map::getNamespaces() code to be based on extension type rather than paths.
Adds library extension support to namespace mapper.
Removes empty component frontend namespaces.
Removes trailing slash from paths.

Testing Instructions

This should be tested on both Linux and Windows.

Delete libraries/autoload_psr4.php file.
Test that Joomla! still works.
Test that com_media works.
Test that System - Debug plugin works when debug is enabled.

Expected result

Works like before.

Documentation Changes Required

IDK.

@richard67
Copy link
Copy Markdown
Member

@wilsonge How is this PR related to the Prepared Statements project?

@richard67
Copy link
Copy Markdown
Member

@SharkyKZ I can test later but only with Linux.

Other testers please report back if Linux or Windows was used so we later can see if both was tested sufficiently.

@810
Copy link
Copy Markdown
Contributor

810 commented Jan 11, 2020

I have tested this item ✅ successfully on 282c48d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27479.

@richard67
Copy link
Copy Markdown
Member

@810 Have you tested with webserver on Linux? Or Windows? Or both?

@810
Copy link
Copy Markdown
Contributor

810 commented Jan 11, 2020

windows only

@richard67
Copy link
Copy Markdown
Member

@810 Thanks for reporting back. Is good to have an overview who tested on what.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jan 11, 2020

I have tested this item ✅ successfully on 282c48d

I've tested successfully with sebserver on Linux.

Have also compared newly created autoloader file with backup, using BeyondCompare (my favourite diff tool). A few frontent namespaces have been removed, guess these are the unused ones mentioned in the description. Frontend and backend still work fine.

Now we have each one good test on Linux and Windows. We need Would be nice to have one more test for each.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27479.

@richard67
Copy link
Copy Markdown
Member

@SharkyKZ We have 2 good tests, one for each server OS type. Shall I give RTC or do you want more tests?

@SharkyKZ
Copy link
Copy Markdown
Contributor Author

Have 2 tests so setting RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27479.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 11, 2020
@wilsonge wilsonge merged commit 3f5f634 into joomla:4.0-dev Jan 21, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 21, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 21, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants