Skip to content

[4.0] Rename Tags route helper class#27511

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/tag-route-helper
Jan 19, 2020
Merged

[4.0] Rename Tags route helper class#27511
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/tag-route-helper

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

Summary of Changes

Renames Joomla\Component\Tags\Site\Helper\TagsHelperRoute to be consistent with other helper classes.

Testing Instructions

Create an article. In the article create some tags on the fly.
View a list of tags and single in frontend.
Run Smart Search indexer.

Expected result

Works like before.

Documentation Changes Required

IDK.

@jwaisner
Copy link
Copy Markdown
Member

I have tested this item 🔴 unsuccessfully on 109659e

After applying patch, frontend breaks with errors.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27511.

@jwaisner
Copy link
Copy Markdown
Member

27511

@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 109659e

repatching resolved missing files. All works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27511.

@wilsonge wilsonge merged commit d9917c3 into joomla:4.0-dev Jan 19, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 19, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants