Skip to content

[4.0] Shorter pinned description#27508

Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom
Quy:23959-pinned
Jan 21, 2020
Merged

[4.0] Shorter pinned description#27508
wilsonge merged 4 commits intojoomla:4.0-devfrom
Quy:23959-pinned

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented Jan 13, 2020

Redo #21879

Testing Instructions

Code review.
or
Edit a banner.
See shorter description under Pinned switcher.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jan 13, 2020
@Quy Quy mentioned this pull request Jan 13, 2020
@brianteeman
Copy link
Copy Markdown
Contributor

All description have not been blindly removed. Only the meaningless and/or useless have been removed

@toivo
Copy link
Copy Markdown
Contributor

toivo commented Jan 15, 2020

I have tested this item ✅ successfully on d5b0b95

Tested in the Nightly build of 15 January.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27508.

@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on d5b0b95


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27508.

@wilsonge
Copy link
Copy Markdown
Contributor

Agree with @brianteeman. The first part of the description Whether or not the Banner is 'pinned' can be removed - but the rest is actually useful information we shouldn't be removing

@Quy Quy changed the title [4.0] Remove pinned description [4.0] Shorter pinned description Jan 21, 2020
@wilsonge wilsonge merged commit 7cab7ec into joomla:4.0-dev Jan 21, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 21, 2020
@Quy Quy deleted the 23959-pinned branch January 21, 2020 16:37
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants