Skip to content

[4.0] [plg_system_httpheaders] Add filters and validation to manifest file#25689

Merged
HLeithner merged 8 commits intojoomla:4.0-devfrom
SharkyKZ:j4/plgSystemHttpHeaders
Jan 16, 2020
Merged

[4.0] [plg_system_httpheaders] Add filters and validation to manifest file#25689
HLeithner merged 8 commits intojoomla:4.0-devfrom
SharkyKZ:j4/plgSystemHttpHeaders

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Summary of Changes

Adds filters and validation to manifest and subform.

Testing Instructions

Apply patch.
Save plugin configuration if this previously saved.

Expected result

Plugin should work like before.

Documentation Changes Required

No.

Copy link
Copy Markdown
Contributor

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as noted inline

Comment thread plugins/system/httpheaders/httpheaders.php Outdated
Comment thread plugins/system/httpheaders/httpheaders.php Outdated
Comment thread plugins/system/httpheaders/httpheaders.php Outdated
SharkyKZ and others added 2 commits July 23, 2019 10:45
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jul 23, 2019

I have tested this item ✅ successfully on 7d86048


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25689.

@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 3696f47


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25689.

Copy link
Copy Markdown
Contributor

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HLeithner HLeithner merged commit 8c41c1c into joomla:4.0-dev Jan 16, 2020
@HLeithner
Copy link
Copy Markdown
Member

Thanks

@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 16, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants