[4.0] Fix undefined property when editing stages/transitions#27874
Merged
richard67 merged 1 commit intojoomla:4.0-devfrom Feb 9, 2020
Merged
[4.0] Fix undefined property when editing stages/transitions#27874richard67 merged 1 commit intojoomla:4.0-devfrom
richard67 merged 1 commit intojoomla:4.0-devfrom
Conversation
Member
|
I have tested this item ✅ successfully on a5bca08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27874. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on a5bca08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27874. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27874. |
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26306
Summary of Changes
Fixes undefined property in error logs when editing a stage or transition.
Testing Instructions
Create a new workflow.
Under Stages column, click the count badge.
Edit Unpublished.
Click Save & Close.
View PHP error log.
Trying to get property 'workflow_id' of non-object in \administrator\components\com_workflow\Model\StageModel.php on line 163Do the same under the Transitions column.
Trying to get property 'workflow_id' of non-object in \administrator\components\com_workflow\Model\TransitionModel.php on line 89After patching neither entries will be added to the error log
Documentation Changes Required
None