[4.0] Main menu add new shortcuts#27788
Conversation
The admin menu module has options to show/hide the "add new" shortcuts on the menu. This option was not working. It is now
Co-Authored-By: Quy <quy@fluxbb.org>
|
On a clean install of your branch, the shortcuts do not appear even though |
|
Just to confirm something can you go to the module and save it - even without changing any settings |
|
After saving, they appear. So the value initially is a string and after saving is an integer. |
|
I thought that was the case. The problem is not here with this code. It is a much bigger problem with the installation sql having the wrong values - and not just for this field |
| } | ||
|
|
||
| if ($currentParams->get('menu-quicktask', false)) | ||
| if ($currentParams->get('menu-quicktask', false) && $this->params->get('shownew', 1) === 1) |
There was a problem hiding this comment.
| if ($currentParams->get('menu-quicktask', false) && $this->params->get('shownew', 1) === 1) | |
| if ($currentParams->get('menu-quicktask', false) && $this->params->get('shownew', 1)) |
There was a problem hiding this comment.
I think I see what you are doing here but isnt this just masking the problem that the data in the sql is wrong.
There was a problem hiding this comment.
This has nothing to do with SQL as it's not changing the default values. It's just that it changes the explicite check to a simple boolean check. Both ways work exactly the same in this case, the proposed solution just is a bit simpler.
|
Is there already an issue or PR for the wrong SQL? Can’t look now, am posting on mobile and will go offline for sleep soon. |
|
I have tested this item ✅ successfully on 8a9e9ec The parameter currently isn't used and this PR adds the corresponding code for it. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27788. |
|
I have tested this item ✅ successfully on 8a9e9ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27788. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27788. |
|
This PR will not display the shortcut icon until |
The admin menu module has options to show/hide the "add new" shortcuts on the menu. This option was not working. It is now
Partial Pull Request for Issue #26050