Skip to content

Merging changes from the main repository#2

Merged
arka204 merged 125 commits intoarka204:masterfrom
scikit-learn:master
May 10, 2020
Merged

Merging changes from the main repository#2
arka204 merged 125 commits intoarka204:masterfrom
scikit-learn:master

Conversation

@arka204
Copy link
Copy Markdown
Owner

@arka204 arka204 commented May 10, 2020

Updating the fork.

lucyleeow and others added 30 commits April 11, 2020 13:10
* replace boston

* fix score
* wording, typo

* add suggestions

* add n est

* remove n est
* added v0.19.1 and wip v0.19

* finished adding vchanged strings for v0.19

Towards #15426

@adrinjalali #wimlds #scikitlearnsprint

* fixing linter issues

* caught line issues with flake8

* caught the last line issue

* added lines and cleaned gtiignore

* Update sklearn/multiclass.py

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

* Update sklearn/multiclass.py

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
* Adding jitter to LassoLars fit

* CircleCI fail

* MR comments

* Jitter becomes default, added test based on issue description

* flake8 fixes

* Removing unexpected cython files

* Better coverage

* PR comments

* PR comments

* PR comments

* PR comments

* PR comments

* Linting

* Apply suggestions from code review

* addressed comments

* added whatnew entry

* test both estimators

* update whatsnew

* removed random_state for lassolarsIC

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-Authored-By: Roman Yurchak <rth.yurchak@gmail.com>
lucyleeow and others added 29 commits April 30, 2020 10:59
* MISC: fix rst syntax

* DOC Adds full link

Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
* Remove sklearn logger default StreamHandler

To avoid duplicate log messages

* DOC Adds whats_new

* CLN Address comments

* MNT Remove setLevel

Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
* ENH Adjusts html_repr based on configuration

* CLN Returns None instead

* CLN Uses property hack

* CLN Address comments
* Added value checks and random state parameter to method

* Changed default parameter to None instead of 0

* Added numpy RandomState to the check

* Replaced inline validation with check_random_state from utils and pointed at glossery

* Needed a different default parameter to pass the default way this has been working in the past

* Updated to conform with flake8 stds

* Add random_state to AffinityPropagation class.

* Add test.

* Add what's new entry and versionadded directive.

* Add PR number.

* Fix lint error due to this PR.

* Use np.array_equal in test.

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* Homogenize parametre descriptions, default random_state to None.

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update doc/whats_new/v0.23.rst

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Change test name.

* Modify check in test.

* Fix lint errors.

* Address comment.

* Address comment.

* Add 'deprecation' and its correspondent test.

* Fix lint errors.

* Add random_state parameter to tests, to avoid FutureWarnings.

* Move warning in fit. Modify tests.

* Modify example.

* Tentative fix for failures.

* Document default value to 0. Revert docstring.

* Explicit link to Glossary.

* Fix default value.

* Remove some warnings from tests.

* Validate and test docstring.

* Tentative fix.

* Tentative fix.

* Ignore FutureWarning in fit attribute test.

* Set random_state to avoid FutureWarning in test_fit_docstring_attributes.

* [doc build] Force documentation build.

* Clarify warning message.

Co-authored-by: rwoolston.admin <rwoolston.admin@LXO-DS-DEV.afcucorp.local>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
* init

* flake8 error by vscode autoformatting

* remove returns

* get_model > get_estimator

* cosmit Tom + autoformat on save error again
@arka204 arka204 merged commit 464dc37 into arka204:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.