DOC Improve neighbors documentation#16923
Merged
thomasjpfan merged 4 commits intoscikit-learn:masterfrom Apr 17, 2020
Merged
Conversation
* Add import to Example in DistanceMetric * Make "Only available to novelty..." bold in LocalFactorOutlier
* Make 4 methods private * Fix class signatures
TomDLT
reviewed
Apr 16, 2020
thomasjpfan
reviewed
Apr 16, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thanks for the PR @haochunchang !
thomasjpfan
approved these changes
Apr 17, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you @haochunchang !
LGTM
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes a todo in #3846
What does this implement/fix? Explain your changes.
As mentioned by steinfurt, they all have at least on examples.
So I fix some format issues rendered in html to make the documentation more consistent.
Besides, I make 4 methods of
BinaryTreeprivate by adding underscore to prevent them from showing in the documentation. I think this change is more considerable.Any other comments?
This is my first contribution. Any advice is appreciated!