[DOC] Issue #14312 - Ensure All Attributes are Documented: OAS: location_ added #17163
Merged
thomasjpfan merged 4 commits intoscikit-learn:masterfrom May 9, 2020
Merged
[DOC] Issue #14312 - Ensure All Attributes are Documented: OAS: location_ added #17163thomasjpfan merged 4 commits intoscikit-learn:masterfrom
thomasjpfan merged 4 commits intoscikit-learn:masterfrom
Conversation
ShrunkCovariance: attributes now in alphabetical order (covariance_,location_,precision_) --> shrinkage not an attribute, but a parameter. False positive? LeDoItWolf: attributes now in alphabetical order (covariance_,location_,precision_,shrinkage_)
ShrunkCovariance: attributes now in alphabetical order (covariance_,location_,precision_) --> shrinkage not an attribute, but a parameter. False positive? LeDoItWolf: attributes now in alphabetical order (covariance_,location_,precision_,shrinkage_)
…ydoc # Conflicts: # sklearn/covariance/_shrunk_covariance.py
Member
|
Is there a discussion where it was decided that attributes should be in alphabetical order? |
Member
thomasjpfan
approved these changes
May 8, 2020
thomasjpfan
requested changes
May 8, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
The 'OAS' can be removed here:
thomasjpfan
approved these changes
May 9, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @hhnnhh !
LGTM
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 11, 2020
adrinjalali
pushed a commit
that referenced
this pull request
May 12, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Issue #14312
What does this implement/fix? Explain your changes.
This adds documentation for an attribute of the OAS function and reorders attributes of ShrunkCovariance and LedoitWolf in alphabetical order.
Any other comments?
ShrunkCovariance: --> shrinkage seems to be a false positive, as it is not an attribute but a parameter for ShrunkCovariance. Hence, shrinkage wasn't added to attributes.