Skip to content

MNT Removed duplicate method calls in pickle estimator test#17152

Merged
NicolasHug merged 2 commits intoscikit-learn:masterfrom
mloning:remove_duplicate_from_pickle_test
May 7, 2020
Merged

MNT Removed duplicate method calls in pickle estimator test#17152
NicolasHug merged 2 commits intoscikit-learn:masterfrom
mloning:remove_duplicate_from_pickle_test

Conversation

@mloning
Copy link
Copy Markdown
Contributor

@mloning mloning commented May 7, 2020

Reference Issues/PRs

Fixes #17149

What does this implement/fix? Explain your changes.

Removes duplicate method calls.

@NicolasHug
Copy link
Copy Markdown
Member

thanks @mloning , looks like your branch is outdated now, I think that's what's causing the CI issue. Try to merge with master, it should fix it

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mloning

@NicolasHug NicolasHug changed the title [MRG] Removed duplicate method calls in pickle estimator test MNT Removed duplicate method calls in pickle estimator test May 7, 2020
@NicolasHug NicolasHug merged commit 89fcef7 into scikit-learn:master May 7, 2020
@NicolasHug
Copy link
Copy Markdown
Member

thanks @mloning

gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate method calls in estimator checks

3 participants