[MRG] MNT Use Vt instead of V as returned by svd()#17100
Merged
rth merged 3 commits intoscikit-learn:masterfrom May 5, 2020
Merged
[MRG] MNT Use Vt instead of V as returned by svd()#17100rth merged 3 commits intoscikit-learn:masterfrom
rth merged 3 commits intoscikit-learn:masterfrom
Conversation
NicolasHug
commented
May 1, 2020
| U *= sqrt(X.shape[0] - 1) | ||
| else: | ||
| # X_new = X * V = U * S * V^T * V = U * S | ||
| # X_new = X * V = U * S * Vt * V = U * S |
Member
Author
There was a problem hiding this comment.
As a side note, this comment and the one above were actually incorrect with the previous notation
thomasjpfan
approved these changes
May 1, 2020
| u and v are the output of `linalg.svd` or | ||
| :func:`~sklearn.utils.extmath.randomized_svd`, with matching inner | ||
| dimensions so one can compute `np.dot(u * s, v)`. | ||
| The input v should really be called vt to be consistent with scipy's |
Member
There was a problem hiding this comment.
For those who specific v as keyword argument?
I am starting to see the argument for pep 570 in (python 3.8).
Member
Author
There was a problem hiding this comment.
Yes, I want to change it too but it's public :/
Definitely a good candidate for pep 570!
Member
Author
|
easy one @rth? |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scipy's
linalg.svdorlinalg.svdreturnX = U, S, Vt.The code uses
Vinstead ofVtin various places. It can get confusing when people are checking out how we do PCA etc...