Skip to content

STY Adjust line height of code blocks#17094

Merged
TomDLT merged 4 commits intoscikit-learn:masterfrom
thomasjpfan:line_hight_code
May 4, 2020
Merged

STY Adjust line height of code blocks#17094
TomDLT merged 4 commits intoscikit-learn:masterfrom
thomasjpfan:line_hight_code

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

While reviewing #17062 the line height of the code blocks seemed a little small. This PR makes it slightly bigger:

this PR

Screen Shot 2020-04-30 at 2 54 48 PM

master

Screen Shot 2020-04-30 at 2 51 10 PM

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would even push it to 1.2em :)

@TomDLT TomDLT merged commit 2cad437 into scikit-learn:master May 4, 2020
@TomDLT
Copy link
Copy Markdown
Member

TomDLT commented May 4, 2020

Much better thanks ! Note that it changes all the examples as well.

adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 11, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants