TST Replace boston in ensemble test_bagging#16921
Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom Apr 15, 2020
Merged
TST Replace boston in ensemble test_bagging#16921thomasjpfan merged 2 commits intoscikit-learn:masterfrom
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
Conversation
thomasjpfan
reviewed
Apr 14, 2020
|
|
||
| ensemble = BaggingRegressor(DecisionTreeRegressor(), | ||
| n_jobs=1, | ||
| n_jobs=3, |
Member
There was a problem hiding this comment.
Although this change is small, it is not related to the title. This can be done with another PR. The main reason for creating a new PR is such that we can discuss this change independently of the rest of the changes. Secondly, less diffs makes this PR easier to merge.
Member
Author
There was a problem hiding this comment.
Point taken, bad habits!
adrinjalali
approved these changes
Apr 15, 2020
thomasjpfan
approved these changes
Apr 15, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @lucyleeow !
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #16155
What does this implement/fix? Explain your changes.
Replace boston dataset with diabetes dataset in
sklearn/ensemble/tests/test_bagging.py.Also amended
test_parallel_regression. I might be mistaken but is the purpose oftest_parallel_regressionto ensure that the results withn_jobsequal to 1, 2 and 3 are all equal?y1andy3are bothn_jobs=1. Alson_jobsis set and then overwritten before being used.Any other comments?