Skip to content

DOC Fix wording, typo in plot_voting_regressor.py#16895

Merged
adrinjalali merged 4 commits intoscikit-learn:masterfrom
lucyleeow:DOC_votereg
Apr 14, 2020
Merged

DOC Fix wording, typo in plot_voting_regressor.py#16895
adrinjalali merged 4 commits intoscikit-learn:masterfrom
lucyleeow:DOC_votereg

Conversation

@lucyleeow
Copy link
Copy Markdown
Member

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

  • Clarify wording of VotingRegressor definition
  • Use from sklearn.datasets import load_diabetes instead of from sklearn import datasets to match convention in other examples
  • Make less wordy and clarify some points

Any other comments?

on the whole dataset. It, then, averages the individual predictions to form a
final prediction.
A voting regressor is an ensemble meta-estimator that fits several base
regressors, each on the whole dataset. It then averages the individual
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
regressors, each on the whole dataset. It then averages the individual
regressors, each on the whole dataset. Then it averages the individual

:class:`~ensemble.RandomForestRegressor`, and
:class:`~linear_model.LinearRegression`).
Then, using them we will make voting regressor
The above 3 regressors will then be used for the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The above 3 regressors will then be used for the
Then the above 3 regressors will be used for the

@lucyleeow
Copy link
Copy Markdown
Member Author

Thanks @thomasjpfan, suggestions added.

@lucyleeow
Copy link
Copy Markdown
Member Author

lucyleeow commented Apr 11, 2020

Also added n_estimators so it corresponds to ensemble.rst - see: https://github.com/scikit-learn/scikit-learn/pull/16876/files#r406913865 nevermind keep as is without n_estimators

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinjalali adrinjalali merged commit a2d361b into scikit-learn:master Apr 14, 2020
@lucyleeow lucyleeow deleted the DOC_votereg branch April 15, 2020 15:14
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
* wording, typo

* add suggestions

* add n est

* remove n est
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants