API make feature_extraction's constructors' params kwonly#16866
Merged
thomasjpfan merged 4 commits intoscikit-learn:masterfrom Apr 15, 2020
Merged
API make feature_extraction's constructors' params kwonly#16866thomasjpfan merged 4 commits intoscikit-learn:masterfrom
thomasjpfan merged 4 commits intoscikit-learn:masterfrom
Conversation
TomDLT
approved these changes
Apr 8, 2020
sklearn/feature_extraction/_hash.py
Outdated
|
|
||
| def __init__(self, n_features=(2 ** 20), input_type="dict", | ||
| @_deprecate_positional_args | ||
| def __init__(self, *, n_features=(2 ** 20), input_type="dict", |
Member
There was a problem hiding this comment.
I feel n_features could be positional, no strong feeling though.
Member
There was a problem hiding this comment.
I am +0.25 on having n_features positional.
thomasjpfan
approved these changes
Apr 10, 2020
sklearn/feature_extraction/_hash.py
Outdated
|
|
||
| def __init__(self, n_features=(2 ** 20), input_type="dict", | ||
| @_deprecate_positional_args | ||
| def __init__(self, *, n_features=(2 ** 20), input_type="dict", |
Member
There was a problem hiding this comment.
I am +0.25 on having n_features positional.
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #15005.
This is an easy one, there doesn't seem to be any parameter which should be positional, I guess.