Skip to content

DOC Remove unnecessary comment#17091

Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
lucyleeow:plot_part_dep
Apr 30, 2020
Merged

DOC Remove unnecessary comment#17091
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
lucyleeow:plot_part_dep

Conversation

@lucyleeow
Copy link
Copy Markdown
Member

@lucyleeow lucyleeow commented Apr 30, 2020

Reference Issues/PRs

What does this implement/fix? Explain your changes.

With update to Sphinx-Gallery config - addition of 'remove_config_comments': True, in #16933, Sphinx-Gallery config comments would be automatically removed so this explanation comment is unnecessary in plot_partial_dependence_visualization_api.py (and confusing when the config comment has been removed in rendered doc)

Any other comments?

@thomasjpfan
Copy link
Copy Markdown
Member

Thank you @lucyleeow !

@thomasjpfan thomasjpfan merged commit 3a6c8c4 into scikit-learn:master Apr 30, 2020
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 4, 2020
adrinjalali pushed a commit that referenced this pull request May 5, 2020
@lucyleeow lucyleeow deleted the plot_part_dep branch May 12, 2020 18:34
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants