[MRG] API kwonly args in impute, inspection, kernel_ridge, and linear_model#16926
Merged
rth merged 10 commits intoscikit-learn:masterfrom Apr 19, 2020
Merged
[MRG] API kwonly args in impute, inspection, kernel_ridge, and linear_model#16926rth merged 10 commits intoscikit-learn:masterfrom
rth merged 10 commits intoscikit-learn:masterfrom
Conversation
thomasjpfan
approved these changes
Apr 15, 2020
TomDLT
approved these changes
Apr 16, 2020
Member
|
tests are failing though |
Member
|
The failures are valid. There are in the codebase that is using position arguments that would raise the |
Member
|
They are valid. Mostly, |
Member
Author
|
All green. |
Member
|
Merging with +3. Thanks! |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
…rn#16926) , and linear_model
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…rn#16926) , and linear_model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #15005.
In the interest of easier review combining changes in
impute,inspection,kernel_ridge, andlinear_modelin this PR.