DOC 0.23/whats_new hotfix#17131
Merged
NicolasHug merged 2 commits intoscikit-learn:masterfrom May 5, 2020
Merged
Conversation
rth
approved these changes
May 5, 2020
Member
rth
left a comment
There was a problem hiding this comment.
LaTex not supporting unicode is another reason to drop it for docs generation.
Member
Author
|
yep, pdflatex fails on it. |
Member
|
I guess we can merge now since the PR CI won't build the latex anyway? Should this just be merged in master as usual? |
Member
Author
|
Yeah it's into master, I'll cherry pick it into the branch in #17120 |
Member
Author
|
I thought |
adrinjalali
added a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 5, 2020
adrinjalali
added a commit
that referenced
this pull request
May 5, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the unicode character in user name.
ping @thomasjpfan @rth @NicolasHug maybe?