Skip to content

DOC Update random_state description for Multiclass#16839

Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
DatenBiene:multiclass
Apr 15, 2020
Merged

DOC Update random_state description for Multiclass#16839
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
DatenBiene:multiclass

Conversation

@DatenBiene
Copy link
Copy Markdown
Contributor

Reference Issue/PR:
partially addressed #10548

Updated the documentation for random_state in :
sklearn/multiclass.py - 687

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM

@cmarmo
Copy link
Copy Markdown
Contributor

cmarmo commented Apr 14, 2020

Hi @DatenBiene failing checks were probably related to issues with dependencies, but the build log is no longer available. Could you please force a build with an empty commit? Thanks for your work!

@cmarmo
Copy link
Copy Markdown
Contributor

cmarmo commented Apr 14, 2020

Could you please force a build with an empty commit?

Sorry @DatenBiene , I'd better say that you probably need to sync with upstream, the dependency issue has been fixed in upstream/master. Thanks for your patience.

@DatenBiene
Copy link
Copy Markdown
Contributor Author

Thanks @thomasjpfan and @cmarmo for the review and thanks for having sync with upstream. Is there still something that I can do?

@thomasjpfan
Copy link
Copy Markdown
Member

This looks good to merge. Thank you for the PR @DatenBiene

@thomasjpfan thomasjpfan changed the title [DOC] Update random_state description for Multiclass DOC Update random_state description for Multiclass Apr 15, 2020
@thomasjpfan thomasjpfan merged commit 9358a6e into scikit-learn:master Apr 15, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants