Fix _deprecate_positional_args for kwonly args w/o default#16850
Merged
NicolasHug merged 2 commits intoscikit-learn:masterfrom Apr 14, 2020
Merged
Fix _deprecate_positional_args for kwonly args w/o default#16850NicolasHug merged 2 commits intoscikit-learn:masterfrom
NicolasHug merged 2 commits intoscikit-learn:masterfrom
Conversation
Member
|
@NicolasHug should be an easy review. |
NicolasHug
approved these changes
Apr 7, 2020
Comment on lines
+1101
to
+1102
| def f3(a, *, b, c=1, d=1): | ||
| pass |
Member
Author
There was a problem hiding this comment.
Added small comment above function.
Contributor
|
@scikit-learn/core-devs , time to merge this one? :) |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
_deprecate_positional_argsfor keyword only arguments w/o defaults arguments i.e.:CC @adrinjalali