Skip to content

DOC User Guide and docs for LDA and QDA#16243

Merged
NicolasHug merged 20 commits intoscikit-learn:masterfrom
NicolasHug:lda_UG
Apr 19, 2020
Merged

DOC User Guide and docs for LDA and QDA#16243
NicolasHug merged 20 commits intoscikit-learn:masterfrom
NicolasHug:lda_UG

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug commented Jan 27, 2020 •
edited
Loading

  • more detailed docstrings for parameters and attributes
  • explain that the output of decision_function is the log posterior
  • explain what coef_ and intercept_ actually are
  • detailed math section to give intuition behind LDA
  • detailed (some) solvers. There are still some of them that I don't understand

@NicolasHug NicolasHug mentioned this pull request Jan 27, 2020
Open
@NicolasHug NicolasHug changed the title [WIP] DOC User Guide and docs for LDA and QDA [MRG] DOC User Guide and docs for LDA and QDA Jan 29, 2020
@NicolasHug NicolasHug mentioned this pull request Jan 31, 2020
Closed
@NicolasHug NicolasHug mentioned this pull request Feb 12, 2020
Open
@NicolasHug
Copy link
Copy Markdown
Member Author

NicolasHug commented Mar 19, 2020

Not sure who to ping for this.
Maybe the usual @glemaitre @adrinjalali @thomasjpfan @rth

@NicolasHug NicolasHug added this to the 0.23 milestone Mar 31, 2020
TomDLT
TomDLT approved these changes Apr 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement ! I might have missed some stuff, but overall it looks good to me.

jnothman
jnothman approved these changes Apr 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks. I've not given this a critical review, but I think it's otherwise good to merge.

NicolasHug
NicolasHug commented Apr 19, 2020
View reviewed changes
@NicolasHug @jnothman
Apply suggestions from code review
c26b583 
Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>
@NicolasHug
Copy link
Copy Markdown
Member Author

NicolasHug commented Apr 19, 2020

Thanks for the review Joel

Since this is only docs and it has a +2, I'll merge when green

@NicolasHug NicolasHug changed the title [MRG] DOC User Guide and docs for LDA and QDA DOC User Guide and docs for LDA and QDA Apr 19, 2020
@NicolasHug NicolasHug merged commit 4d9478f into scikit-learn:master Apr 19, 2020
@NicolasHug NicolasHug deleted the lda_UG branch April 19, 2020 20:55
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@NicolasHug @gio8tisu
DOC User Guide and docs for LDA and QDA (scikit-learn#16243)
0a3a1b9
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@NicolasHug @viclafargue
DOC User Guide and docs for LDA and QDA (scikit-learn#16243)
8e98295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

+1 more reviewer

@TomDLT TomDLT TomDLT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.23

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasHug @jnothman @TomDLT