Skip to content

chore: moves e2e selectors to tests#25764

Merged
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-selectors-to-test-v2
Feb 6, 2026
Merged

chore: moves e2e selectors to tests#25764
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-selectors-to-test-v2

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 6, 2026

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR also:

  • moves E2E specific selectors to /tests

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Primarily import-path and file-location changes for test-only code; main risk is broken tests if any selector/helper paths were missed or mis-referenced.

Overview
Refactors E2E and WDIO test code to centralize selectors under tests/selectors (and multichain helpers under tests/helpers) instead of e2e/selectors / e2e/utils, updating imports across browser, onboarding, ramps, send, settings, stake, swaps, and WDIO screen objects.

Moves MultichainUtilities into the tests helper space and fixes its internal import paths (app NETWORKS_CHAIN_ID and test createLogger), then updates multichain smoke tests to consume the new helper location and selector paths (including MULTICHAIN_TEST_TIMEOUTS).

Written by Cursor Bugbot for commit bb2047b. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested review from a team as code owners February 6, 2026 10:30
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) labels Feb 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the size-S label Feb 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeMultiChainAPI, FlaskBuildTests, SmokeNetworkExpansion, SmokeTrade, SmokeRamps, SmokeIdentity, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a pure refactoring of E2E test infrastructure - moving selector files from e2e/selectors/ to tests/selectors/ and utility files from e2e/utils/ to tests/helpers/, then updating all import paths accordingly. No actual test logic or selector values are changed.

The changes affect multiple test areas:

  1. SmokeMultiChainAPI: Directly affected - multichain test specs (wallet-createSession, wallet-getSession, wallet-revokeSession, wallet-sessionChanged) have updated imports for MultichainUtilities and MultichainTestDapp selectors
  2. FlaskBuildTests: Directly affected - test-snap-background-events.spec.ts has updated import for TestSnaps.selectors
  3. SmokeNetworkExpansion: Affected via SolanaTestDApp.ts import path changes
  4. SmokeTrade: Affected via QuoteView.ts, SlippageModal.ts, and swaps/OnBoarding.ts import path changes
  5. SmokeRamps: Affected via BuyGetStartedView.ts, SelectPaymentMethodView.ts, SelectRegionView.ts, SellGetStartedView.ts import path changes
  6. SmokeIdentity: Affected via BackupAndSyncView.ts import path changes
  7. SmokeConfirmations: Affected via RedesignedSendView.ts and SendActionBottomSheet.ts import path changes (send flows)

The wdio/ changes are for a separate test framework (WebDriverIO/Appwright) and don't require Detox tags.

Since this is infrastructure refactoring that could break tests if import paths are incorrect, running the affected test suites validates the changes work correctly. The risk is medium because while the changes are straightforward path updates, any typo or incorrect path would cause test failures.

Performance Test Selection:
This PR is purely a test infrastructure refactoring that moves selector files and updates import paths. No application code, UI components, data loading logic, or performance-critical paths are modified. The changes only affect E2E test file organization and have no impact on app performance.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2026

Copy link
Copy Markdown
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snaps changes look good to me.

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit b5081f6 Feb 6, 2026
136 of 168 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-selectors-to-test-v2 branch February 6, 2026 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-S skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants