Skip to content

chore: move tools to tests#25198

Merged
christopherferreira9 merged 2 commits intomainfrom
cferreira/move-tools-tests
Jan 26, 2026
Merged

chore: move tools to tests#25198
christopherferreira9 merged 2 commits intomainfrom
cferreira/move-tools-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 26, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves tools to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Centralizes E2E analyzer tooling under tests/tools and aligns paths across codebase.

  • Updates paths from e2e/tools/e2e-ai-analyzer to tests/tools/e2e-ai-analyzer in .github script, README, CLI help text, and usage examples
  • Adjusts ESLint overrides to lint tests/tools/**/* instead of e2e/tools/**/*
  • Updates e2e/tags.js comment reference and select-tags handler import to pull tags from e2e/tags
  • Tweaks EXCLUDED_TAGS in select-tags/handlers.ts (adds several tags like SmokeStake, SmokeNotifications, etc.)

No functional logic changes to analyzer/tools beyond path and small config updates.

Written by Cursor Bugbot for commit fa581c4. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner January 26, 2026 15:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 26, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 26, 2026
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 26, 2026
@github-actions github-actions bot added size-S and removed size-M labels Jan 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 26, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

This PR is a pure file relocation/refactoring that moves the e2e-ai-analyzer tool from e2e/tools/ to tests/tools/. All 26 files in the e2e-ai-analyzer directory are being renamed/moved with either 100% similarity (no content changes) or 95% similarity (only path reference updates in documentation/help text).

The changes include:

  1. Moving all e2e-ai-analyzer files to the new location
  2. Updating path references in e2e/tags.js (comment only)
  3. Updating the CI script (.github/scripts/e2e-smart-selection.mjs) to use the new path
  4. Updating ESLint configuration to apply rules to the new directory
  5. Updating documentation and help text with new paths

No functional changes are made to:

  • Application code
  • E2E test specs
  • E2E test infrastructure (pages, fixtures, utils)
  • Test execution logic

The e2e-ai-analyzer is a CI tool used for PR analysis, not part of the actual E2E test execution. This refactoring does not affect any user-facing functionality or test behavior, making it safe to skip E2E tests.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 26, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 59dd549 Jan 26, 2026
57 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-tools-tests branch January 26, 2026 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 26, 2026
@metamaskbot metamaskbot added release-7.64.0 Issue or pull request that will be included in release 7.64.0 and removed release-7.65.0 Issue or pull request that will be included in release 7.65.0 labels Feb 3, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 3, 2026

Missing release label release-7.64.0 on PR. Adding release label release-7.64.0 on PR and removing other release labels(release-7.65.0), as PR was added to branch 7.64.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-S team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christopherferreira9 @metamaskbot @tommasini