Skip to content

chore: move controller-mocking to tests#24988

Merged
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-controller-mocking-tests
Jan 21, 2026
Merged

chore: move controller-mocking to tests#24988
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-controller-mocking-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 21, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves controller-mocking to /tests.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Centralizes controller-mocking under tests/ and aligns all references.

  • Updates all Perps E2E bridge/test imports from e2e/controller-mocking/... to tests/controller-mocking/...
  • Adds tests/**/* to ESLint overrides and tsconfig.json includes
  • Revises e2e/docs/CONTROLLER_MOCKING.md paths to point to tests/controller-mocking/...
  • Keeps E2E bridge behavior intact while changing module locations and require paths

Written by Cursor Bugbot for commit 0627900. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner January 21, 2026 15:34
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

This PR is a pure refactoring change that moves controller mocking files from e2e/controller-mocking/ to tests/controller-mocking/ and updates all references accordingly. The changes include:

  1. File renames: perps-controller-mixin.ts and perps-e2e-mocks.ts moved from e2e/controller-mocking/ to tests/controller-mocking/
  2. Path updates: All dynamic require paths in app/components/UI/Perps/utils/e2eBridgePerps.ts and its test files updated to point to new location
  3. Config updates: .eslintrc.js and tsconfig.json updated to include the new tests/ directory
  4. Documentation update: e2e/docs/CONTROLLER_MOCKING.md updated with new file paths

No actual logic or behavior changes - this is purely a file reorganization. However, since the Perps E2E tests rely on this mocking infrastructure (the e2eBridgePerps.ts bridge dynamically requires these files during E2E test runs), running SmokePerps will verify that the path changes don't break the Perps E2E testing functionality.

The risk is low because:

  • All path references have been consistently updated
  • The file contents remain unchanged (100% similarity)
  • This is a well-scoped refactoring with clear intent

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 129cc7c Jan 21, 2026
108 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-controller-mocking-tests branch January 21, 2026 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jvbriones jvbriones jvbriones approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-S team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christopherferreira9 @jvbriones @gambinish @metamaskbot