chore: refactor testId selectors to avoid imports from app to e2e#24313
Merged
chore: refactor testId selectors to avoid imports from app to e2e#24313
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
399815e to
2060c3f
Compare
7 tasks
brianacnguyen
previously approved these changes
Jan 12, 2026
6aabc5a to
f1cdef1
Compare
f1cdef1 to
34e741a
Compare
34e741a to
178804e
Compare
Gudahtt
previously approved these changes
Jan 13, 2026
Gudahtt
previously approved these changes
Jan 13, 2026
c170ee2 to
60471d1
Compare
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
Gudahtt
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR aims to refactor test ID definitions to follow proper architectural guidelines by moving them from
e2e/selectors/into the application code. App code was importing test IDs from thee2e/folder, creating an incorrect dependency where production code depends on test infrastructure. This moves test ID definitions toapp/code as*.testIds.tsfiles, co-located with their respective components. E2E page objects now import test IDs from app code instead of vice versa.Changes
*.testIds.tsfiles inapp/alongside their componentsapp/imports to use local testIds filese2e/page object imports to reference new app locationse2e/are test related files and are not imported inapp/Example
Before
After
Notes
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors test ID ownership and imports to align with architecture (app code no longer imports from
e2e/).*.testIds.tsfiles alongside components and updates all app/tests to import from these modules (e.g.,CellComponent.testIds,BrowserURLBar.testIds,TokenOverview.testIds,Network*...testIds, Perps/Predict testIds, etc.)e2e/selectors/*imports from app code; E2E can now consume IDs from app modulesas consttypings on IDs, localized path fixes foren.json, and small selector text/ID adjustmentsWritten by Cursor Bugbot for commit 60471d1. This will update automatically on new commits. Configure here.