Skip to content

chore: moves api-specs and seeder to tests#25095

Merged
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-seeder-api-specs
Jan 23, 2026
Merged

chore: moves api-specs and seeder to tests#25095
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-seeder-api-specs

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 23, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves api-specs and seeder to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Centralizes E2E test assets by relocating api-specs and seeder under tests/, updating all references, and aligning CI/local runners.

  • Paths/Imports: Mass updates from e2e/api-specs → tests/smoke/api-specs and e2e/seeder → tests/seeder across numerous E2E specs and test utilities
  • Detox config: Points iOS apiSpecs runner to tests/smoke/api-specs/run-api-spec-tests.js
  • Docs: Updates API Spec test locations and links in docs/readme/e2e-testing.md
  • Test infra: Adjusts framework utilities (e.g., PortManager, FixtureUtils, MockServerE2E) to new tests/seeder paths

Written by Cursor Bugbot for commit 6ee10a9. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested review from a team as code owners January 23, 2026 11:20
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 23, 2026
@christopherferreira9 christopherferreira9 added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Jan 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 23, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 changed the title chore: moves api-specs to tests chore: moves api-specs and seeder to tests Jan 23, 2026
@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 3c57620 Jan 23, 2026
104 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-seeder-api-specs branch January 23, 2026 19:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 23, 2026
@metamaskbot metamaskbot added release-7.64.0 Issue or pull request that will be included in release 7.64.0 and removed release-7.65.0 Issue or pull request that will be included in release 7.65.0 labels Feb 3, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 4, 2026

No release label on PR. Adding release label release-7.64.0 on PR, as PR was added to branch 7.64.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@jvbriones jvbriones jvbriones approved these changes

@gantunesr gantunesr gantunesr approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-M skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@christopherferreira9 @metamaskbot @FrederikBolding @jvbriones @gantunesr @gambinish