Skip to content

chore: moves api-mocking and framework to tests#25031

Merged
christopherferreira9 merged 7 commits intomainfrom
cferreira/move-framework-api-mocking-test
Jan 22, 2026
Merged

chore: moves api-mocking and framework to tests#25031
christopherferreira9 merged 7 commits intomainfrom
cferreira/move-framework-api-mocking-test

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 22, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves framework and api-mocking to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Consolidates E2E tooling under tests/ and updates the codebase accordingly.

  • Migrates TypeScript E2E framework and API mocking from e2e/framework and e2e/api-mocking to tests/framework and tests/api-mocking
  • Updates imports across E2E specs, page objects, helpers, Playwright config, and select app-side test utilities to reference tests/framework/* and tests/api-mocking/*
  • Adjusts .eslintrc.js extends path, BUGBOT rules, and E2E documentation links to the new locations
  • Updates CODEOWNERS and security code scanner ignore paths to reflect tests/
  • Removes obsolete e2e/framework re-export files no longer used

Written by Cursor Bugbot for commit 635d96f. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run labels Jan 22, 2026
@christopherferreira9 christopherferreira9 requested review from a team as code owners January 22, 2026 10:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 22, 2026
@christopherferreira9 christopherferreira9 added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jan 22, 2026
@christopherferreira9
Copy link
Copy Markdown
Contributor Author

christopherferreira9 commented Jan 22, 2026

Added skip sonar as the results are flagging issues with untouched files that aren't being used at all: https://sonarcloud.io/dashboard?id=metamask-mobile&pullRequest=25031

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 22, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Mrtenz
Mrtenz approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snaps changes look good.

gantunesr
gantunesr approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accounts changes looks good

cortisiko
cortisiko approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit ffe70fa Jan 22, 2026
173 of 181 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-framework-api-mocking-test branch January 22, 2026 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matallui matallui matallui approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

@cortisiko cortisiko cortisiko approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@gantunesr gantunesr gantunesr approved these changes

@gambinish gambinish gambinish approved these changes

@sophieqgu sophieqgu sophieqgu approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-XL skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@christopherferreira9 @matallui @Mrtenz @cortisiko @MarioAslau @Prithpal-Sooriya @gantunesr @gambinish @sophieqgu @metamaskbot