Skip to content

chore: moves wallet, accounts and analytics specs to tests#25263

Merged
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-wallet-accounts-settings-spec-files-tests
Jan 27, 2026
Merged

chore: moves wallet, accounts and analytics specs to tests#25263
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-wallet-accounts-settings-spec-files-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 27, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Wallet, settings, analytics and accounts /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Centralizes E2E/regression/smoke specs and analytics helpers under the tests/ hierarchy.

  • Moves multiple wallet, settings, accounts, swaps, ramps, and analytics specs to tests/regression and tests/smoke, updating imports to tests/framework and tests/helpers/analytics/helpers
  • Introduces/relocates tests/helpers/analytics/helpers.ts and aligns all specs to use it for event capture utilities
  • Minor comment added in .github/scripts/e2e-split-tags-shards.mjs regarding BASE_DIR performance; no functional change

No app/runtime code changes; CI/test paths and mocks updated accordingly.

Written by Cursor Bugbot for commit 89d3a83. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested review from a team as code owners January 27, 2026 12:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 27, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 27, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeWalletPlatform, SmokeCard, SmokeRewards, SmokePredictions, SmokeRamps, SmokeTrade, FlaskBuildTests, SmokeConfirmationsRedesigned
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

This PR is a large-scale test infrastructure reorganization that moves test spec files from e2e/specs/ to a new tests/ directory structure (with tests/smoke/ and tests/regression/ subdirectories) and relocates the shared analytics helpers from e2e/specs/analytics/helpers.ts to tests/helpers/analytics/helpers.ts.

The changes are purely structural - no application code is modified, and no test logic or assertions are changed. All modifications are:

  1. File renames/moves to new directory locations
  2. Import path updates to reflect the new file locations
  3. A minor comment addition to the CI script explaining the BASE_DIR change

However, since this affects the test infrastructure itself, running tests is important to validate:

  • Import paths are correctly updated and tests can find their dependencies
  • The CI script can still discover and execute tests from the new locations
  • Tests still function correctly after the migration

The affected test categories based on the moved files include:

  • SmokeAccounts: reveal-secret-recovery-phrase.spec.ts, wallet-details.spec.ts moved
  • SmokeWalletPlatform: Multiple wallet tests moved (analytics, connections, settings, incoming-transactions, import-srp)
  • SmokeCard: All card tests moved (card-button, card-home-add-funds, card-home-manage-card)
  • SmokeRewards: rewards.spec.ts and rewards.mocks.ts moved
  • SmokePredictions: Import path updates in predict tests
  • SmokeRamps: onramp-parameters.spec.ts import path updated
  • SmokeTrade: swap-action-smoke.spec.ts import path updated
  • FlaskBuildTests: test-snap-preinstalled.spec.ts import path updated
  • SmokeConfirmationsRedesigned: dapp-initiated-transfer.spec.ts import path updated

Running these tags will validate the test migration was successful and all import paths are correct.

View GitHub Actions results

@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 27, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (0f5817f) to head (89d3a83).
⚠️ Report is 117 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #25263      +/-   ##
==========================================
+ Coverage   79.96%   80.02%   +0.06%     
==========================================
  Files        4257     4267      +10     
  Lines      109331   109881     +550     
  Branches    22889    23021     +132     
==========================================
+ Hits        87429    87936     +507     
- Misses      15835    15843       +8     
- Partials     6067     6102      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 27, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

caieu
caieu approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 27, 2026
@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit ba5c1f5 Jan 27, 2026
100 of 101 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-wallet-accounts-settings-spec-files-tests branch January 27, 2026 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2026
@metamaskbot metamaskbot added release-7.65.0 Issue or pull request that will be included in release 7.65.0 release-7.64.0 Issue or pull request that will be included in release 7.64.0 and removed release-7.65.0 Issue or pull request that will be included in release 7.65.0 labels Jan 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@caieu caieu caieu approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@VGR-GIT VGR-GIT VGR-GIT approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-L team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@christopherferreira9 @codecov-commenter @caieu @FrederikBolding @VGR-GIT @tommasini @metamaskbot