chore: moves Multichain specs to tests#25638
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…a/move-multichain-specs
tests/smoke/multichain/connections/multiple-provider-connections.spec.ts
Show resolved
Hide resolved
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
No functional test logic is changed - only the file organization and import paths. However, since these are E2E test infrastructure changes, we should run the affected tests to validate the refactoring works correctly. The affected tests cover:
Per tag dependencies:
No SmokeConfirmations needed as the Solana tests being moved don't include transaction confirmation flows in this specific set of changes. Performance Test Selection: |
|
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Following #24313 we're looking to centralize all tools and test resources in one place. This PR moves spec files for `Multichain` to `/tests`. Previous related PRs: - #24988 - #24313 - #25031 - #25095 - #25167 - #25198 - #25219 - #25263 - #25279 - #25520 - #25533 - #25598 - #25636 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235 ## **Manual testing steps** N/A ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** N/A <!-- [screenshots/recordings] --> ### **After** N/A <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only refactor that mainly updates import paths and shared helpers; low product risk but could break CI if any paths/exports are misaligned. > > **Overview** > **Refactors multichain E2E/spec organization under `tests/`** by updating multichain regression/smoke specs to import pages/tags/view helpers from the centralized `e2e/` location and test utilities from `tests/framework`. > > Extracts/relocates shared test utilities into reusable modules: `tests/flows/solana-connection.flow.ts` for Solana dapp connection/navigation helpers and `tests/helpers/multichain/connections/helpers.ts` for a common `wallet_requestPermissions` script helper (plus a small logger name tweak). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d89337a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->



Description
Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for
Multichainto/tests.Previous related PRs:
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Test-only refactor that mainly updates import paths and shared helpers; low product risk but could break CI if any paths/exports are misaligned.
Overview
Refactors multichain E2E/spec organization under
tests/by updating multichain regression/smoke specs to import pages/tags/view helpers from the centralizede2e/location and test utilities fromtests/framework.Extracts/relocates shared test utilities into reusable modules:
tests/flows/solana-connection.flow.tsfor Solana dapp connection/navigation helpers andtests/helpers/multichain/connections/helpers.tsfor a commonwallet_requestPermissionsscript helper (plus a small logger name tweak).Written by Cursor Bugbot for commit d89337a. This will update automatically on new commits. Configure here.