Skip to content

chore: moves Multichain specs to tests#25638

Merged
christopherferreira9 merged 7 commits intomainfrom
cferreira/move-multichain-specs
Feb 5, 2026
Merged

chore: moves Multichain specs to tests#25638
christopherferreira9 merged 7 commits intomainfrom
cferreira/move-multichain-specs

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 4, 2026

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Multichain to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only refactor that mainly updates import paths and shared helpers; low product risk but could break CI if any paths/exports are misaligned.

Overview
Refactors multichain E2E/spec organization under tests/ by updating multichain regression/smoke specs to import pages/tags/view helpers from the centralized e2e/ location and test utilities from tests/framework.

Extracts/relocates shared test utilities into reusable modules: tests/flows/solana-connection.flow.ts for Solana dapp connection/navigation helpers and tests/helpers/multichain/connections/helpers.ts for a common wallet_requestPermissions script helper (plus a small logger name tweak).

Written by Cursor Bugbot for commit d89337a. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@christopherferreira9 christopherferreira9 changed the title chore: moves Confirmations specs to tests chore: moves Multichain specs to tests Feb 4, 2026
@metamaskbot metamaskbot added the team-qa QA team label Feb 4, 2026
@github-actions github-actions bot added the size-M label Feb 4, 2026
@christopherferreira9 christopherferreira9 added the skip-e2e skip E2E test jobs label Feb 4, 2026
Base automatically changed from cferreira/move-confirmations-specs-tests to main February 4, 2026 14:09
@christopherferreira9 christopherferreira9 removed the skip-e2e skip E2E test jobs label Feb 4, 2026
@christopherferreira9 christopherferreira9 added the skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) label Feb 4, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeNetworkExpansion, SmokeNetworkAbstractions, SmokeMultiChainAPI
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a test infrastructure refactoring that moves E2E test files from e2e/specs/multichain/ to a new tests/ directory structure (tests/smoke/multichain/ and tests/regression/multichain/). All changes are:

  1. File renames/relocations: Moving test spec files and helper files to new directory structure
  2. Import path updates: Updating all import statements to reflect new relative paths

No functional test logic is changed - only the file organization and import paths. However, since these are E2E test infrastructure changes, we should run the affected tests to validate the refactoring works correctly.

The affected tests cover:

  • SmokeNetworkExpansion: Solana wallet standard tests (connect, signMessage, transferSol), multiple provider connections, permission system initial connection, and regression tests for account/chain permission revocation
  • SmokeNetworkAbstractions: Permission system summary, chain permission discard changes, dApp chain switch grant tests
  • SmokeMultiChainAPI: wallet_createSession, wallet_getSession, wallet_revokeSession, wallet_sessionChanged API tests

Per tag dependencies:

  • SmokeMultiChainAPI requires SmokeNetworkAbstractions (permission UI) and SmokeNetworkExpansion (multi-chain provider) - both included
  • SmokeNetworkExpansion integrates with SmokeNetworkAbstractions - both included

No SmokeConfirmations needed as the Solana tests being moved don't include transaction confirmation flows in this specific set of changes.

Performance Test Selection:
These changes are purely test infrastructure refactoring - moving test files to a new directory structure and updating import paths. No application code is changed, no UI components are modified, and no performance-critical paths are affected. The changes don't impact app rendering, data loading, state management, or any user-facing functionality that would warrant performance testing.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 4, 2026

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 4, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 4, 2026
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Following #24313 we're
looking to centralize all tools and test resources in one place.
This PR moves spec files for `Multichain` to `/tests`.

Previous related PRs:
- #24988
- #24313
- #25031
- #25095
- #25167
- #25198
- #25219
- #25263
- #25279
- #25520
- #25533
- #25598
- #25636


<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235

## **Manual testing steps**
N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
N/A
<!-- [screenshots/recordings] -->

### **After**
N/A
<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Test-only refactor that mainly updates import paths and shared
helpers; low product risk but could break CI if any paths/exports are
misaligned.
> 
> **Overview**
> **Refactors multichain E2E/spec organization under `tests/`** by
updating multichain regression/smoke specs to import pages/tags/view
helpers from the centralized `e2e/` location and test utilities from
`tests/framework`.
> 
> Extracts/relocates shared test utilities into reusable modules:
`tests/flows/solana-connection.flow.ts` for Solana dapp
connection/navigation helpers and
`tests/helpers/multichain/connections/helpers.ts` for a common
`wallet_requestPermissions` script helper (plus a small logger name
tweak).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d89337a. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2026
@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit f42efdd Feb 5, 2026
147 of 161 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-multichain-specs branch February 5, 2026 01:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants