Skip to content

chore: moves Ramps, Multisrp, Swap and Assets specs to tests#25279

Merged
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-assets-ramps-multisrp-tests
Jan 30, 2026
Merged

chore: moves Ramps, Multisrp, Swap and Assets specs to tests#25279
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-assets-ramps-multisrp-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Jan 27, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Assets, MultiSRP, Swap and Ramps to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Test-only refactor, but it touches many specs and import paths; the main risk is broken CI/test execution due to module resolution or path mismatches.

Overview
Moves and rewires test specs to run from tests/ (notably Assets, Ramps, and Multi-SRP-related coverage), updating imports to consistently reference shared e2e page objects, tags, and tests fixtures/mocking utilities.

Centralizes SRP/account helpers by switching various specs from local multisrp/utils helpers to tests/flows/accounts.flow.ts (goToImportSrp, inputSrp, completeSrpQuiz, etc.), and adjusts accounts.flow.ts itself to import UI page objects from e2e/pages and framework utilities from tests/framework.

Written by Cursor Bugbot for commit 95ebe1f. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner January 27, 2026 17:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 27, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 27, 2026
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 27, 2026
@christopherferreira9 christopherferreira9 force-pushed the cferreira/move-assets-ramps-multisrp-tests branch from 3c9ed4f to 95ebe1f Compare January 30, 2026 15:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 30, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeIdentity, SmokeWalletPlatform, SmokeConfirmationsRedesigned, SmokeNetworkAbstractions, SmokeTrade, SmokeRamps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR only modifies E2E specs and test utilities: consolidates multisrp helpers into tests/flows/accounts.flow.ts and renames/moves many specs across assets, ramps, multisrp, DeFi, and transaction flows. No app/core/Engine or controller code changed. The primary risk is broken imports, fixtures, and cross-suite helpers affecting account/SRP flows, wallet details, transaction confirmations, assets/DeFi screens, and ramps flows. To validate safely with minimal overhead, run smoke suites covering these areas: accounts/SRP (SmokeAccounts), identity sync (SmokeIdentity), wallet platform navigation and account hierarchy (SmokeWalletPlatform), transaction/confirmation UI (SmokeConfirmationsRedesigned), network abstractions used by assets/DeFi lists (SmokeNetworkAbstractions), Trade (stake action) flows (SmokeTrade), and on/off-ramp smoke (SmokeRamps). Broader areas like Snaps, Perps, Predictions, Card, MultiChainAPI, NetworkExpansion are untouched and can be skipped.

Performance Test Selection:
No application or performance-sensitive code paths (controllers, Engine, rendering components) changed—only test files and utilities. No expected impact on runtime performance, so performance tests are not required.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 6d5ff23 Jan 30, 2026
95 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-assets-ramps-multisrp-tests branch January 30, 2026 23:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christopherferreira9 @gantunesr @metamaskbot