Skip to content

chore: moves Confirmations specs to tests#25636

Merged
christopherferreira9 merged 2 commits intomainfrom
cferreira/move-confirmations-specs-tests
Feb 4, 2026
Merged

chore: moves Confirmations specs to tests#25636
christopherferreira9 merged 2 commits intomainfrom
cferreira/move-confirmations-specs-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 4, 2026

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Confrimations to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only refactor that mainly rewires import paths and fixture/resource locations; risk is limited to breaking e2e/smoke test execution due to incorrect paths or module resolution.

Overview
Centralizes Confirmations e2e specs under tests/ by updating smoke/regression specs to import shared tooling from the new tests/framework, tests/api-mocking, tests/seeder, and e2e/pages locations.

Updates Anvil/local-node fixtures to load the EIP-7702 delegator state from the new ./tests/smoke/confirmations/transactions/7702/withDelegatorContracts.json path, and adjusts supporting helpers (e.g., analytics/metrics validation) to the new module layout.

Written by Cursor Bugbot for commit a800be4. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a test file reorganization that moves E2E test spec files from e2e/specs/ to a new tests/smoke/confirmations/ directory structure. All 22 changed files are E2E test files related to confirmations functionality:

  1. Send tests: send-native-token, send-erc20-token, send-btc-token, send-solana-token, send-tron-token
  2. Signature tests: signatures, signatures-typed, alert-system
  3. Transaction tests: contract-deployment, contract-interaction, dapp-initiated-transfer, per-dapp-selected-network, transaction-pay
  4. Token approve tests: approve, increase-allowance, set-approval-for-all
  5. EIP-7702 tests: batch-transaction, gas-fee-tokens-eip-7702, gas-fee-tokens-eip-7702-sponsored
  6. Regression test: new-networks-signatures

All these tests are tagged with SmokeConfirmations (or RegressionConfirmations). The changes are purely structural:

  • File relocations from e2e/specs/ to tests/smoke/confirmations/
  • Import path updates to reflect new directory structure
  • File path reference updates in test fixtures (e.g., withDelegatorContracts.json path)

No application code or test logic is modified. Running SmokeConfirmations is essential to verify that:

  1. All import paths are correctly updated
  2. File references in test fixtures work correctly
  3. The test infrastructure still functions after the reorganization

This is a medium risk change because incorrect import paths could break tests, but the scope is limited to test infrastructure only.

Performance Test Selection:
This PR only reorganizes E2E test files by moving them to a new directory structure and updating import paths. No application code is changed, no UI components are modified, and no performance-critical code paths are affected. The changes are purely structural test infrastructure changes that do not impact app performance in any way.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 4, 2026

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit c9c1424 Feb 4, 2026
92 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-confirmations-specs-tests branch February 4, 2026 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-L team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants