Skip to content

chore: moves swap, wallet and Trending specs to tests#25520

Merged
christopherferreira9 merged 2 commits intomainfrom
cferreira/move-swaps-trending-tests
Feb 2, 2026
Merged

chore: moves swap, wallet and Trending specs to tests#25520
christopherferreira9 merged 2 commits intomainfrom
cferreira/move-swaps-trending-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 2, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Trending, Wallet, Swaps to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: this is a test-only reorganization that mainly updates import paths and consolidates swap/bridge helper utilities, with no product/runtime logic changes.

Overview
Moves Swap/Bridge, Trending, and Wallet (mUSD) E2E specs to the tests/ tree and updates imports to use the new tests/framework, tests/helpers, and e2e/pages locations.

Centralizes swap/bridge test utilities under tests/helpers/swap (e.g., swap-unified-ui, prepareSwapsTestEnvironment, swap-mocks, bridge-mocks) and updates affected specs (smoke/regression/quarantine) to consume these shared helpers and mocks.

Written by Cursor Bugbot for commit 2b49165. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 2, 2026
@github-actions github-actions bot added the size-M label Feb 2, 2026
@christopherferreira9 christopherferreira9 changed the title test: moves swap, wallet and Trending specs to tests chore: moves swap, wallet and Trending specs to tests Feb 2, 2026
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a test infrastructure refactoring that moves test files and helpers from e2e/specs/ to tests/ directory structure. The changes include:

  1. Swap helpers moved: e2e/specs/swaps/helpers/ → tests/helpers/swap/ (bridge-mocks.ts, constants.ts, prepareSwapsTestEnvironment.ts, swap-mocks.ts, swap-unified-ui.ts)

  2. Swap spec files moved: e2e/specs/swaps/ → tests/smoke/swap/ and tests/regression/swap/ (bridge-action-smoke.spec.ts, gasless-swap.spec.ts, swap-action-smoke.spec.ts, swap-deeplink-smoke.spec.ts, unified-ui-wallet-actions.spec.ts, swap-token-chart.spec.ts)

  3. Trending spec files moved: e2e/specs/trending/ → tests/smoke/trending/ (trending-browser.spec.ts, trending-feed.spec.ts, trending-search.spec.ts)

  4. Wallet spec files moved: e2e/specs/wallet/ → tests/smoke/wallet/ (musd-conversion-happy-path.spec.ts, helpers/musd-fixture.ts)

  5. Quarantine file updated: Import paths updated in swap-action-regression.failing.ts

All changes are import path updates to reflect new file locations - no functional changes to test logic. The tests use SmokeTrade tag (swap tests) and SmokeWalletPlatform tag (trending and wallet tests). Running these tags will verify the refactored tests still work correctly with the new import paths.

Performance Test Selection:
This PR only reorganizes test files and updates import paths. No application code is changed, no UI components are modified, and no performance-critical paths are affected. The changes are purely test infrastructure refactoring with no impact on app performance.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 2, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2026
@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit 82c8c6e Feb 2, 2026
96 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-swaps-trending-tests branch February 2, 2026 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christopherferreira9 @cortisiko @metamaskbot