Skip to content

chore: moves Identity, Multihain-Accounts and Notifications specs#25533

Merged
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-identity-notifications-multichain-accounts-tests
Feb 3, 2026
Merged

chore: moves Identity, Multihain-Accounts and Notifications specs#25533
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-identity-notifications-multichain-accounts-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 2, 2026

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Notifications, Identity and Multichain-accounts specs to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are confined to test code and Jest configuration, but broad import-path rewrites could still break CI test discovery or shared helpers if any path is missed.

Overview
Moves Identity, Notifications, Multichain Accounts (and related network) E2E/spec coverage under tests/ and updates a wide set of specs/helpers to import shared pages, tags, fixtures, mocks, and utilities from the new locations.

Updates test infrastructure references accordingly (e.g., notification mock helpers now sourced from tests/smoke/notifications/...) and tweaks package.json test:unit to run jest against ./tests/**/*.test.ts instead of ./e2e/**/*.test.ts, reflecting the new test layout.

Written by Cursor Bugbot for commit e7ef33f. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested review from a team as code owners February 2, 2026 18:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 2, 2026
@christopherferreira9 christopherferreira9 changed the title chore: moves Identity, Multihain-Accounts and Notifications specs to … chore: moves Identity, Multihain-Accounts and Notifications specs Feb 2, 2026
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 2, 2026
@github-actions github-actions bot added the size-M label Feb 2, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Copy link
Copy Markdown
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Accounts CO

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 2, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 2, 2026
…5533)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Following #24313 we're
looking to centralize all tools and test resources in one place.
This PR moves spec files for `Notifications`, `Identity` and
`Multichain-accounts` specs to `/tests`.

Previous related PRs:
- #24988
- #24313
- #25031
- #25095
- #25167
- #25198
- #25219
- #25263
- #25279
- #25520


<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: changes are confined to test code and Jest configuration,
but broad import-path rewrites could still break CI test discovery or
shared helpers if any path is missed.
> 
> **Overview**
> Moves Identity, Notifications, Multichain Accounts (and related
network) E2E/spec coverage under `tests/` and updates a wide set of
specs/helpers to import shared pages, tags, fixtures, mocks, and
utilities from the new locations.
> 
> Updates test infrastructure references accordingly (e.g., notification
mock helpers now sourced from `tests/smoke/notifications/...`) and
tweaks `package.json` `test:unit` to run `jest` against
`./tests/**/*.test.ts` instead of `./e2e/**/*.test.ts`, reflecting the
new test layout.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e7ef33f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeIdentity, SmokeNetworkAbstractions, SmokeAccounts, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a large-scale test file reorganization that moves E2E test spec files from e2e/specs/ to tests/smoke/ and tests/regression/ directories. The changes include:

  1. File renames/moves: All test spec files are being moved to new locations with updated import paths
  2. Import path updates: All relative imports in the moved files are updated to reflect the new directory structure
  3. Shared utility updates: FixtureHelper.ts, mockHelpers.ts, and musd-mocks.ts are updated to reference the new file locations
  4. package.json update: Unit test path changed from ./e2e/**/*.test.ts to ./tests/**/*.test.ts

The affected test categories based on the moved files:

  • SmokeIdentity: Account syncing tests (settings toggle, adding/renaming accounts, discovery, imported accounts, multi-srp) and contact syncing tests
  • SmokeNetworkAbstractions: Network manager tests, add popular networks tests, notification settings tests
  • SmokeAccounts: Multichain account details tests (account-details.spec.ts uses RegressionWalletPlatform but tests account functionality)
  • SmokeWalletPlatform: Delete account tests, import SRP tests, analytics import wallet tests

While this is purely a test infrastructure change (no application code changes), running the affected test tags is important to verify:

  1. All import paths are correctly updated
  2. The test framework can still locate and execute the moved tests
  3. Shared utilities (FixtureHelper, mockHelpers) work correctly with the new paths

The risk is medium because incorrect import paths could cause test failures, but the actual application functionality is not affected.

Performance Test Selection:
This PR is purely a test file reorganization that moves E2E test spec files to new directories and updates import paths. No application code is changed - only test infrastructure files are affected. There are no changes to UI components, data loading, state management, or any code paths that would impact app performance. Therefore, no performance tests are needed.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 3, 2026

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 2276a93 Feb 3, 2026
133 of 167 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-identity-notifications-multichain-accounts-tests branch February 3, 2026 11:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants