chore: moves Identity, Multihain-Accounts and Notifications specs#25533
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…5533) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Following #24313 we're looking to centralize all tools and test resources in one place. This PR moves spec files for `Notifications`, `Identity` and `Multichain-accounts` specs to `/tests`. Previous related PRs: - #24988 - #24313 - #25031 - #25095 - #25167 - #25198 - #25219 - #25263 - #25279 - #25520 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are confined to test code and Jest configuration, but broad import-path rewrites could still break CI test discovery or shared helpers if any path is missed. > > **Overview** > Moves Identity, Notifications, Multichain Accounts (and related network) E2E/spec coverage under `tests/` and updates a wide set of specs/helpers to import shared pages, tags, fixtures, mocks, and utilities from the new locations. > > Updates test infrastructure references accordingly (e.g., notification mock helpers now sourced from `tests/smoke/notifications/...`) and tweaks `package.json` `test:unit` to run `jest` against `./tests/**/*.test.ts` instead of `./e2e/**/*.test.ts`, reflecting the new test layout. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e7ef33f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
The affected test categories based on the moved files:
While this is purely a test infrastructure change (no application code changes), running the affected test tags is important to verify:
The risk is medium because incorrect import paths could cause test failures, but the actual application functionality is not affected. Performance Test Selection: |
|



Description
Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for
Notifications,IdentityandMultichain-accountsspecs to/tests.Previous related PRs:
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: changes are confined to test code and Jest configuration, but broad import-path rewrites could still break CI test discovery or shared helpers if any path is missed.
Overview
Moves Identity, Notifications, Multichain Accounts (and related network) E2E/spec coverage under
tests/and updates a wide set of specs/helpers to import shared pages, tags, fixtures, mocks, and utilities from the new locations.Updates test infrastructure references accordingly (e.g., notification mock helpers now sourced from
tests/smoke/notifications/...) and tweakspackage.jsontest:unitto runjestagainst./tests/**/*.test.tsinstead of./e2e/**/*.test.ts, reflecting the new test layout.Written by Cursor Bugbot for commit e7ef33f. This will update automatically on new commits. Configure here.