Skip to content

chore: moves Perps and Performance specs to tests#25598

Merged
christopherferreira9 merged 5 commits intomainfrom
cferreira/move-perps-performance-specs-tests
Feb 4, 2026
Merged

chore: moves Perps and Performance specs to tests#25598
christopherferreira9 merged 5 commits intomainfrom
cferreira/move-perps-performance-specs-tests

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 3, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Performance, and Perps specs to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk refactor focused on test/CI path updates; main risk is broken imports or missing artifacts causing E2E/performance CI runs to fail.

Overview
Centralizes Perps regression/smoke specs and smoke performance specs under tests/, updating imports to reference the tests/framework utilities and shared e2e/pages objects.

Updates performance reporting to write JSON outputs under tests/smoke/performance/reports and adjusts Bitrise + .gitignore to collect/ignore performance result artifacts from the new location (instead of e2e/specs/performance/reports).

Written by Cursor Bugbot for commit 9d0216b. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner February 3, 2026 17:57
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 3, 2026
@github-actions github-actions bot added the size-M label Feb 3, 2026
cursor[bot]
cursor bot reviewed Feb 3, 2026
View reviewed changes
@christopherferreira9 christopherferreira9 requested a review from a team as a code owner February 3, 2026 18:21
cursor[bot]
cursor bot reviewed Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner February 3, 2026 18:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps
  • Selected Performance tags: @PerformanceAccountList
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a test infrastructure reorganization that moves test files from e2e/specs/ to a new tests/ directory structure. The changes include:

  1. Perps test files: Moved from e2e/specs/perps/ to tests/smoke/perps/ and tests/regression/perps/, with import paths updated accordingly
  2. Performance test files: Moved from e2e/specs/performance/ to tests/smoke/performance/
  3. Performance reporter: Renamed from e2e/utils/PerformanceTestReporter.ts to tests/reporters/DetoxPerformanceTestReporter.ts
  4. CI configuration: Updated bitrise.yml to reference new paths for performance test reports
  5. Gitignore: Updated to reflect new performance results path

All changes are purely structural (file renames and import path updates) with no functional changes to test logic. The tests still use the same tags (SmokePerps, RegressionTrade, SmokePerformance).

Running SmokePerps tests will validate that the perps test reorganization works correctly and the import paths resolve properly. This is important because broken imports would cause test failures.

Performance Test Selection:
The PR moves performance test files from e2e/specs/performance/ to tests/smoke/performance/ and renames the PerformanceTestReporter. The account-list and network-list performance tests have been reorganized with updated import paths. Running @PerformanceAccountList will validate that the performance test infrastructure reorganization works correctly - ensuring the reporter path changes and test file relocations don't break the performance testing pipeline. This is a direct change to performance test infrastructure.

View GitHub Actions results

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.43%. Comparing base (a6e8590) to head (9d0216b).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #25598   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files        4286     4286           
  Lines      110981   110977    -4     
  Branches    23614    23614           
=======================================
- Hits        89266    89264    -2     
+ Misses      15513    15512    -1     
+ Partials     6202     6201    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 3, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit 65f1d33 Feb 4, 2026
88 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-perps-performance-specs-tests branch February 4, 2026 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@cortisiko cortisiko cortisiko approved these changes

@gambinish gambinish gambinish approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@christopherferreira9 @codecov-commenter @cortisiko @gambinish @tommasini @metamaskbot