Skip to content

chore: moves quarantine specs to tests; deprecates e2e/specs#25706

Merged
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-quarantine-deprecate-e2e-specs
Feb 5, 2026
Merged

chore: moves quarantine specs to tests; deprecates e2e/specs#25706
christopherferreira9 merged 3 commits intomainfrom
cferreira/move-quarantine-deprecate-e2e-specs

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 5, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR also:

  • moves the quarantined specs to /tests. These quarantine files are now in their respective folder (smoke and regression) instead of using a dedicated quarantine folder.
  • updates BUGBOT.md to review the proper location for e2e tests
  • jest configs for both E2E and unit tests
  • updates documentation to reflect the complete migration of all spec files to /tests
  • reverts back the search of e2e specs in CI. It is now scoped to tests since all specs have been migrated.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches CI/Jest test discovery and sharding logic, so misconfigured paths could cause E2E suites to be skipped or incorrectly partitioned; changes are largely mechanical path updates.

Overview
Shifts Detox E2E spec discovery to tests/ (smoke/regression) and deprecates e2e/specs, updating Jest configs, unit-test ignore patterns, CI sharding/tag selection scripts, and result parsing assumptions accordingly.

Updates documentation and AI review guidance to reference the new tests/(smoke|regression) layout, and rewrites quarantined smoke/regression spec files’ imports to point at shared e2e/ page objects/helpers while using tests/framework + tests/resources from their new locations.

Written by Cursor Bugbot for commit 76eeb92. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner February 5, 2026 12:56
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) labels Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the size-L label Feb 5, 2026
cursor[bot]
cursor bot reviewed Feb 5, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeRamps, SmokeTrade, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a test infrastructure reorganization that:

  1. Moves quarantined test files from e2e/specs/quarantine/ to tests/smoke/ and tests/regression/ directories
  2. Updates Jest configuration (e2e/jest.e2e.config.js) to only look in tests/ for test files (removing e2e/specs/)
  3. Updates CI scripts (.github/scripts/e2e-split-tags-shards.mjs) to use ./tests/ as the base directory
  4. Updates documentation and guidelines to reflect the new directory structure

The moved files are all .failing.ts files (quarantined tests that don't run in CI), so the actual test execution won't be affected by the file moves. However, the configuration changes to e2e/jest.e2e.config.js and the CI scripts could potentially affect test discovery for existing working tests.

I'm selecting a representative set of tags to validate that the test infrastructure changes work correctly:

  • SmokeAccounts: Tests exist in tests/smoke/accounts/ (e.g., reveal-secret-recovery-phrase.spec.ts, wallet-details.spec.ts)
  • SmokeRamps: Tests exist in tests/smoke/ramps/ (e.g., offramp-token-amount.spec.ts)
  • SmokeTrade: Tests exist in tests/smoke/swap/ (e.g., swap-action-smoke.spec.ts, bridge-action-smoke.spec.ts)
  • SmokeWalletPlatform: Tests exist in tests/smoke/wallet/ (e.g., import-srp.spec.ts, incoming-transactions.spec.ts)

This selection covers different feature areas to ensure the test discovery and execution pipeline works correctly after the configuration changes. The risk is medium because while the changes are infrastructure-focused and the moved files are quarantined, the configuration changes could potentially break test discovery if not implemented correctly.

Performance Test Selection:
This PR only reorganizes test file locations and updates configuration/documentation. No application code is changed that would affect UI rendering, data loading, app startup, or any user-facing performance. The changes are purely test infrastructure reorganization (moving .failing.ts files, updating Jest config paths, updating CI scripts). No performance tests are needed.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

MarioAslau
MarioAslau approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit bcf0c8d Feb 5, 2026
181 of 190 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-quarantine-deprecate-e2e-specs branch February 5, 2026 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@jvbriones jvbriones jvbriones approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-L skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christopherferreira9 @jvbriones @NicolasMassart @MarioAslau @metamaskbot