Skip to content

chore: moves snaps specs to tests#25698

Merged
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-snaps-specs
Feb 5, 2026
Merged

chore: moves snaps specs to tests#25698
christopherferreira9 merged 1 commit intomainfrom
cferreira/move-snaps-specs

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented Feb 5, 2026 •
edited by cursor bot
Loading

Description

Following #24313 we're looking to centralize all tools and test resources in one place.
This PR moves spec files for Snaps to /tests.

Previous related PRs:

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1235

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Purely test-only changes that primarily update module paths; risk is limited to potential breakage of the smoke test runner due to incorrect import resolution.

Overview
Refactors the Snaps smoke test suite under tests/smoke/snaps to align with the new centralized testing layout by updating imports from the old tests/ locations to e2e/ pages/helpers and local tests/ framework/fixtures.

Updates related mocks and helpers (e.g., mockGenesisBlocks, remote feature flag mocks) to reference the relocated api-mocking utilities, without changing test logic or assertions.

Written by Cursor Bugbot for commit 91a67a8. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner February 5, 2026 10:22
@christopherferreira9 christopherferreira9 added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) labels Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the size-M label Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: FlaskBuildTests
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR reorganizes the Snaps E2E test infrastructure by moving all 24 test files from e2e/specs/snaps/ to tests/smoke/snaps/. The changes are purely structural:

  1. File relocations: All snaps test files (test-snap-*.spec.ts and mocks.ts) are renamed/moved to the new directory
  2. Import path updates: All import statements are updated to reflect the new relative paths (e.g., ../../tags → ../../../e2e/tags, ../../../tests/framework/ → ../../framework/)
  3. No functional changes: The test logic, assertions, and test cases remain unchanged

The FlaskBuildTests tag is the appropriate choice because:

  • All 24 changed files are Snaps-related test files
  • These tests cover snap lifecycle, dialogs, ethereum provider, BIP-32/44, cronjobs, state management, WASM, JSX, interactive UI, and more
  • Running these tests will validate that the file reorganization and import path changes are correct

This is a medium-risk change because incorrect import paths could cause test failures, but the changes are straightforward path adjustments with no logic modifications.

Performance Test Selection:
This PR only reorganizes test files by moving them from one directory to another and updating import paths. There are no changes to application code, UI components, data loading, or any functionality that could impact app performance. Performance tests are not needed for test infrastructure reorganization.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 818fdae Feb 5, 2026
122 of 158 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-snaps-specs branch February 5, 2026 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christopherferreira9 @Mrtenz @metamaskbot