Skip to content

Fix broken shortcode post embeds.#6474

Merged
dereksmart merged 2 commits intomasterfrom
fix/broken-shortcode-embeds
Feb 22, 2017
Merged

Fix broken shortcode post embeds.#6474
dereksmart merged 2 commits intomasterfrom
fix/broken-shortcode-embeds

Conversation

@zinigor
Copy link
Copy Markdown
Contributor

@zinigor zinigor commented Feb 22, 2017

Fixes #6380. Combines #6381 by @stoyan0v and #6402 by @torounit , thank you both!

Changes proposed in this Pull Request:

  • Fix posts preview when Shortcode Embeds is enabled. For some reason the iframe code is replaced by link on the following line.
  • I am not sure that the changes I've made are the best way to fix this, so I will be happy if @eliorivero can take a look, since he was made this module and is familiar with it.
  • add test for modules/shortcodes/class.filter-embedded-html-objects.php.

Testing instructions:

  • Enable Shortcode embeds
  • Add new post, paste URL for an already published post into visual editor
  • Make sure that it's converted to embedded preview

@zinigor zinigor added [Feature] Shortcodes / Embeds [Status] Ready to Merge Go ahead, you can push that green button! Bug When a feature is broken and / or not performing as intended labels Feb 22, 2017
This was referenced Feb 22, 2017
Closed
Closed
dereksmart
dereksmart approved these changes Feb 22, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@dereksmart dereksmart merged commit c7eb3cb into master Feb 22, 2017
@dereksmart dereksmart deleted the fix/broken-shortcode-embeds branch February 22, 2017 19:07
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 22, 2017
@jeherve jeherve added [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Feb 27, 2017
jeherve added a commit that referenced this pull request Feb 28, 2017
@jeherve
Changelog: add #6474
0165ff4
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
@ghost
Copy link
Copy Markdown

ghost commented Mar 1, 2017 •
edited by ghost
Loading

I am happy that this is fixed 😄

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

No one assigned

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Pri] High

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shortcode Embeds: Breaks embeds of previously published posts

5 participants

@zinigor @dereksmart @jeherve @stoyan0v @torounit