Skip to content

Fix posts preview when Shortcode Embeds is enabled#6381

Closed
stoyan0v wants to merge 1 commit intoAutomattic:masterfrom
stoyan0v:fix/shortcode-embeds/broken-embeds
Closed

Fix posts preview when Shortcode Embeds is enabled#6381
stoyan0v wants to merge 1 commit intoAutomattic:masterfrom
stoyan0v:fix/shortcode-embeds/broken-embeds

Conversation

@stoyan0v
Copy link
Copy Markdown
Contributor

Fixes #6380

Changes proposed in this Pull Request:

  • Fix posts preview when Shortcode Embeds is enabled. For some reason the iframe code is replaced by link on the following line.
    I am not sure that the changes I've made are the best way to fix this, so I will be happy if @eliorivero can take a look, since he was made this module and is familiar with it.

Testing instructions:

  • Enable Shortcode embeds
  • Add new post, paste URL for an already published post into visual editor
  • Make sure that it's converted to embedded preview

@stoyan0v stoyan0v force-pushed the fix/shortcode-embeds/broken-embeds branch from 1964ded to 5494c46 Compare February 13, 2017 13:16
@jeherve jeherve added [Feature] Shortcodes / Embeds [Pri] Normal [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Feb 13, 2017
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some spaces inside the braces, as mentioned here?

Thanks!

@jeherve jeherve added [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Feb 13, 2017
@stoyan0v stoyan0v force-pushed the fix/shortcode-embeds/broken-embeds branch from 88dc468 to d6af436 Compare February 13, 2017 14:51
@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 13, 2017
@zinigor
Copy link
Copy Markdown
Contributor

zinigor commented Feb 22, 2017

Closing in favour of #6474, thank you!

@zinigor zinigor closed this Feb 22, 2017
@zinigor zinigor removed the [Status] Needs Review This PR is ready for review. label Feb 22, 2017
dereksmart pushed a commit that referenced this pull request Feb 22, 2017
* Check if the string contains iframe and skip replacement if so

* test for modules/shortcodes/class.filter-embedded-html-objects.php

Related #6381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortcode Embeds: Breaks embeds of previously published posts

3 participants