Skip to content

Comments: fix validation errors#6316

Merged
samhotchkiss merged 4 commits intomasterfrom
fix/comments-validation-errors
Feb 10, 2017
Merged

Comments: fix validation errors#6316
samhotchkiss merged 4 commits intomasterfrom
fix/comments-validation-errors

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Feb 7, 2017

Follow up of #2683

Fixes the issue reported here. https://wordpress.org/support/topic/please-fix-w3-validation-errors?replies=1&view=all

props @shahthepro

Changes proposed in this Pull Request:

  • apply properties that are no longer valid in HTML 5 using JavaScript.

Testing instructions:

  • Test the Comments form. It should look and behave the same before and after this PR.
  • Feel free to check validation if you want, but with allowTransparency, frameborder and scrolling removed, this validates well (at least what is the scope of this PR).

Proposed changelog entry for your changes:

Comments: fix W3 validation errors regarding allowTransparency, frameborder and scrolling.

@eliorivero eliorivero added [Feature] Comments [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Feb 7, 2017
@eliorivero eliorivero self-assigned this Feb 7, 2017
…erty, prefix function name so it doesn't conflict, remove unneeded comment, format code.
@eliorivero eliorivero force-pushed the fix/comments-validation-errors branch from 41f4e3d to abc4447 Compare February 7, 2017 20:49
@singerb singerb added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 9, 2017
@singerb
Copy link
Copy Markdown
Contributor

singerb commented Feb 9, 2017

Comments look the same before and after, and still work; W3 validation fails on this element before, passes after (still some failures on other shortcodes, but not on comments). Looks good.

@samhotchkiss samhotchkiss merged commit c0c06f1 into master Feb 10, 2017
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 10, 2017
@eliorivero eliorivero deleted the fix/comments-validation-errors branch February 10, 2017 05:01
jeherve added a commit that referenced this pull request Feb 21, 2017
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Comments [Pri] Low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants