Fixes Jetpack Comments Validation Errors#2683
Fixes Jetpack Comments Validation Errors#2683shahthepro wants to merge 3 commits intoAutomattic:masterfrom
Conversation
|
It seems like your PR removes some of the changes introduced in 0d29082. Could you make sure your PR only includes the changes you want to see in Jetpack? Thanks! |
|
Related: #1071 |
|
@jeherve Check this commit shahthepro@4cbb498 It is what you meant, right? |
|
Yes, exactly! 👍 |
modules/comments/comments.php
Outdated
There was a problem hiding this comment.
I'm worried that there could be more than 1 comment form on a page, as specially if we are in a loop. In that case getElementById may not be reliable. Is there a CSS property that we can make use of?
There was a problem hiding this comment.
@roccotripaldi Check this commit 27926fe
Haven't tested it though. But, It should work however.
Updated the selectors as per the suggestion from @roccotripaldi
There was a problem hiding this comment.
@shahthepro is the overflow: hidden necessary? it wasn't there previously and while testing this, I removed it and didn't notice any issue.
|
Moved out of the pipeline until @shahthepro addresses @eliorivero's concerns and rebases |
|
@eliorivero -- if you want to go ahead and make the changes you recommended here, that'd be great! |
|
Closing in favor of #6316 where the commits from author have been cherry picked. |
Fixes the issue reported here. https://wordpress.org/support/topic/please-fix-w3-validation-errors?replies=1&view=all