Skip to content

Widget Visibility: replace text labels with × and + icons#3406

Merged
thingalon merged 1 commit intomasterfrom
fix/widget-visibility-long-select
Feb 9, 2017
Merged

Widget Visibility: replace text labels with × and + icons#3406
thingalon merged 1 commit intomasterfrom
fix/widget-visibility-long-select

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Feb 12, 2016 •
edited
Loading

Small screen sizes have been taken into account, as well as its display in Customize.
Previous text labels "Delete" and "Add" were kept, albeit hidden, to preserve accesibility.

❗ _Note_: before testing this, run gulp old-styles to build the minified css file used in Widgets and Customize

fixes #3382

@eliorivero eliorivero added Bug When a feature is broken and / or not performing as intended [Feature] Widget Visibility [Status] Needs Review This PR is ready for review. labels Feb 12, 2016
@eliorivero eliorivero added this to the 3.9.2 milestone Feb 12, 2016
@zinigor zinigor modified the milestones: 4.0, 3.9.2 Feb 18, 2016
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Jun 21, 2016

Whether I run grunt or not, the Visibility button disappears from the Customizer when I check out that branch.

Do you experience the same issue?

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jun 21, 2016
@jeherve jeherve modified the milestones: 4.2, 4.1 Jun 21, 2016
@jeherve jeherve modified the milestones: 4.3, 4.2 Jul 6, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@jeherve jeherve modified the milestone: 4.4 Jul 8, 2016
@samhotchkiss samhotchkiss modified the milestones: Not Currently Planned, 4.4 Nov 9, 2016
@samhotchkiss samhotchkiss reopened this Nov 9, 2016
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Nov 30, 2016

#5781

@eliorivero eliorivero force-pushed the fix/widget-visibility-long-select branch from 6a6b826 to db784d8 Compare February 6, 2017 21:57
@eliorivero
Copy link
Copy Markdown
Contributor Author

eliorivero commented Feb 6, 2017

I don't experience that issue. Back when I wrote this I tested it in Customizer and just did it again now and it's all good.
I've rebased master on this PR to catch up with latest improvements.
To test this, gulp old-styles must be run.

@eliorivero eliorivero added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 6, 2017
@jeherve jeherve force-pushed the fix/widget-visibility-long-select branch from db784d8 to 97f17cc Compare February 8, 2017 14:33
jeherve
jeherve approved these changes Feb 8, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and works well! 🚢

(Note: I had to rebase to include 3bb2660 and be able to run gulp)

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 8, 2017
@thingalon
Copy link
Copy Markdown
Member

thingalon commented Feb 9, 2017

Works for me (after running gulp old-styles). Rollin' it. @eliorivero, will we need to do anything to the build process to make this work after merging?

@thingalon thingalon merged commit 46ff723 into master Feb 9, 2017
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 9, 2017
@eliorivero eliorivero deleted the fix/widget-visibility-long-select branch February 9, 2017 04:16
@eliorivero
Copy link
Copy Markdown
Contributor Author

eliorivero commented Feb 9, 2017

Thanks @thingalon. Nothing else is needed. These styles are generated when the build to be released is created.

jeherve added a commit that referenced this pull request Feb 21, 2017
@jeherve
Changelog: add #3406
a22ea7d
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
This was referenced Mar 6, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

No one assigned

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Widget Visibility [Status] Needs Design Review Design has been added. Needs a review! [Status] Requires String Changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Widget Visibility: option gets deleted by mistake on i18n interfaces

8 participants

@eliorivero @jeherve @thingalon @zinigor @samhotchkiss @richardmuscat @dereksmart @matticbot