Skip to content

API: Add a filter for theme info results#6446

Merged
seear merged 2 commits intomasterfrom
add/themes-endpoint-filter
Feb 20, 2017
Merged

API: Add a filter for theme info results#6446
seear merged 2 commits intomasterfrom
add/themes-endpoint-filter

Conversation

@seear
Copy link
Copy Markdown
Contributor

@seear seear commented Feb 20, 2017

Adds a filter that allows modification of the array of information returned for a theme by any of the Jetpack theme endpoints.

Will be used by wpcomsh plugin to tweak one of the fields to indicate whether or not a given theme is a wpcom theme.

Adds a filter that allows modification of the array of information
returned for a theme by any of the Jetpack theme endpoints.

Will be used by wpcomsh plugin to tweak one of the fields to
indicate whether or not a given theme is a wpcom theme.
@seear seear added [Feature] WPCOM API [Status] Needs Review This PR is ready for review. labels Feb 20, 2017
@seear seear self-assigned this Feb 20, 2017
@seear seear requested a review from lamosty February 20, 2017 15:00
@briancolinger
Copy link
Copy Markdown
Contributor

Looks good to me. Works as expected and nothing breaks!

* @module json-api
* @since 4.7
* @param array $formatted_theme The theme info array
* @returns array The filtered theme info array
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpDoc likes @return

@returns is JSDoc

@dereksmart
Copy link
Copy Markdown
Contributor

Feel free to merge after fixing phpDoc!

Copy link
Copy Markdown
Contributor

@lamosty lamosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

@seear
Copy link
Copy Markdown
Contributor Author

seear commented Feb 20, 2017

Thanks for the reviews, all!

@seear seear merged commit 92a2a10 into master Feb 20, 2017
@seear seear deleted the add/themes-endpoint-filter branch February 20, 2017 17:33
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Feb 20, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants