Skip to content

Add filter for WordPress Posts widget content#5883

Merged
thingalon merged 2 commits intoAutomattic:masterfrom
stoyan0v:add/wodpress-posts-widget-content-filter
Feb 8, 2017
Merged

Add filter for WordPress Posts widget content#5883
thingalon merged 2 commits intoAutomattic:masterfrom
stoyan0v:add/wodpress-posts-widget-content-filter

Conversation

@stoyan0v
Copy link
Copy Markdown
Contributor

@stoyan0v stoyan0v commented Dec 15, 2016 •
edited
Loading

Changes proposed in this Pull Request:

Add a filter to WordPress Posts widget content, so it will allow to be overwritten.
Issue: #4075

Testing instructions:

  • Create a function and hook it to jetpack_display_posts_widget_content
  • Modify the $content and return it at the end.
  • Example:
add_filter( 'jetpack_display_posts_widget_content', 'change_wordpress_posts_widget_content' );
function change_wordpress_posts_widget_content( $content ) {
	// Change the widget content
	$content = '<h1>Hello world</h1>';
	
	return $content;
}

@jeherve jeherve added [Feature] Extra Sidebar Widgets [Pri] Low [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Dec 15, 2016
@jeherve jeherve added this to the 4.6 milestone Dec 15, 2016
@stoyan0v stoyan0v force-pushed the add/wodpress-posts-widget-content-filter branch from 753405a to 1a5a288 Compare December 23, 2016 10:40
@jeherve jeherve modified the milestones: 2/17 - February, 4.7.0 - March 2017 Jan 30, 2017
@samhotchkiss samhotchkiss removed this from the 4.7.0 - March 2017 milestone Feb 3, 2017
eliorivero
eliorivero suggested changes Feb 6, 2017
View reviewed changes
modules/widgets/wordpress-post-widget.php Outdated
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function esc_html_e outputs instead of returning and will break this.
Replace this with esc_html__.

Copy link
Copy Markdown
Contributor Author

@stoyan0v stoyan0v Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been replaced. Thank you.

modules/widgets/wordpress-post-widget.php Outdated
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialization of $content to '' is redundant and you can initialize it to $args['before_widget'].

Copy link
Copy Markdown
Contributor Author

@stoyan0v stoyan0v Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eliorivero eliorivero added [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Feb 6, 2017
@stoyan0v stoyan0v force-pushed the add/wodpress-posts-widget-content-filter branch from 1a5a288 to e7beb84 Compare February 7, 2017 07:50
eliorivero
eliorivero approved these changes Feb 7, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for the contribution!

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 7, 2017
@thingalon
Copy link
Copy Markdown
Member

thingalon commented Feb 8, 2017

Works well, looks good. Merging.

@thingalon thingalon merged commit fbd7c17 into Automattic:master Feb 8, 2017
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 8, 2017
@thingalon thingalon mentioned this pull request Feb 8, 2017
Closed
jeherve added a commit that referenced this pull request Feb 8, 2017
@jeherve
Changelog: add #5883
86ed7ec 
Also update the filter's docblock to match new version.
jeherve added a commit that referenced this pull request Feb 21, 2017
@jeherve
Changelog: add #5883
e6fed77 
Also update the filter's docblock to match new version.
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eliorivero eliorivero eliorivero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Pri] Low Touches WP.com Files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stoyan0v @thingalon @eliorivero @jeherve @samhotchkiss @matticbot