Skip to content

Carousel: allow to filter EXIF tags that will be displayed in lightbox#6352

Merged
samhotchkiss merged 1 commit intomasterfrom
update/carousel-allow-more-exif-tags
Feb 10, 2017
Merged

Carousel: allow to filter EXIF tags that will be displayed in lightbox#6352
samhotchkiss merged 1 commit intomasterfrom
update/carousel-allow-more-exif-tags

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Feb 9, 2017 •
edited
Loading

Fixes #861

Changes proposed in this Pull Request:

  • display "Copyright" tag
  • allow to filter the EXIF tags that will be included.
    They can be added now using something like this: 
    function jp_custom_exif_info( $js ) {
	// Add tag to list
	$js['meta_data'][] = 'credit';

	// Add translation for tag
	$js['credit'] = __( 'Credit', 'jetpack' );

	return $js;
} 
add_filter( 'jp_carousel_localize_strings', 'jp_custom_exif_info');
    The filter also allows to redefine the tags that will be displayed by overwriting the list with a full array instead of appending an item like in the previous example: 
    function jp_custom_exif_info( $js ) {
	// Overwrite with a new list
	$js['meta_data'] = array( 'copyright', 'credit' );

	// Add translation for tag
	$js['credit'] = __( 'Credit', 'jetpack' );

	return $js;
} 
add_filter( 'jp_carousel_localize_strings', 'jp_custom_exif_info');
  • the styles will prevent the exif data blocks from being incorrectly stacked
    With previous styles, the last block is incorrectly floated towards right
    captura de pantalla 2017-02-09 a las 22 05 36
    With the updated styles, the last block is correctly placed towards left
    captura de pantalla 2017-02-09 a las 22 05 51

Testing instructions:

  • use an image with copyright field in the EXIF metadata

Proposed changelog entry for your changes:

Carousel: now displays copyright EXIF information if it's available and allows to define custom EXIF information to display.

@eliorivero eliorivero added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 9, 2017
@eliorivero eliorivero self-assigned this Feb 9, 2017
@eliorivero eliorivero requested a review from jeherve February 9, 2017 22:05
@thingalon
Copy link
Copy Markdown
Member

thingalon commented Feb 10, 2017

LGTM, and looks like it works:

jpdev___just_another_wordpress_site

@thingalon thingalon added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 10, 2017
@eliorivero eliorivero force-pushed the update/carousel-allow-more-exif-tags branch from 3cfe596 to 11df999 Compare February 10, 2017 01:04
@samhotchkiss samhotchkiss merged commit adbde22 into master Feb 10, 2017
@samhotchkiss samhotchkiss deleted the update/carousel-allow-more-exif-tags branch February 10, 2017 05:05
@samhotchkiss samhotchkiss added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 10, 2017
@jeherve jeherve added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Feb 10, 2017
@eliorivero eliorivero mentioned this pull request Feb 10, 2017
Closed
@jeherve jeherve added [Status] Has Changelog and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Feb 20, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
@jeherve
Changelog: add #6352
ecf3495
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve Awaiting requested review from jeherve

Assignees

@eliorivero eliorivero

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eliorivero @thingalon @jeherve @samhotchkiss