Skip to content

Settings: update highlight color for selected stats range#6418

Merged
dereksmart merged 1 commit intomasterfrom
update/stats-range-highlight
Feb 15, 2017
Merged

Settings: update highlight color for selected stats range#6418
dereksmart merged 1 commit intomasterfrom
update/stats-range-highlight

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Feb 14, 2017

Fixes #3871

Changes proposed in this Pull Request:

  • updates the highlight color used for stats range

captura de pantalla 2017-02-09 a las 15 58 50

This is a change that doesn't depend on the new UI so can be merged at any point.

Testing instructions:

  • go to At a Glance, the stats range tabs should highlight in black as go through them

Proposed changelog entry for your changes:

Stats: the highlight of the stats range was updated for easier spotting and to make it consistent with other areas of the dashboard.

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 14, 2017
@eliorivero eliorivero added this to the Settings UI milestone Feb 14, 2017
@eliorivero eliorivero self-assigned this Feb 14, 2017
@eliorivero eliorivero removed this from the Settings UI milestone Feb 14, 2017
@dereksmart dereksmart modified the milestone: Settings UI Feb 15, 2017
Copy link
Copy Markdown
Contributor

@georgestephanis georgestephanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks completely reasonable -- but would it be wiser to use a named color variable instead of a hex code?

@georgestephanis georgestephanis added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 15, 2017
@dereksmart
Copy link
Copy Markdown
Contributor

@georgestephanis I think using the wp-core variable ($base-color) in this case would cause it to be a different color if the wp-admin theme is changed, which probably won't look good with our colors. I'm ok with hard-coding here.

@dereksmart dereksmart merged commit 6634478 into master Feb 15, 2017
@dereksmart dereksmart deleted the update/stats-range-highlight branch February 15, 2017 19:54
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 15, 2017
@jeherve jeherve added [Focus] Accessibility Improving usability for all users (a11y) [Status] Needs Changelog and removed [Status] Needs Changelog labels Feb 15, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Accessibility Improving usability for all users (a11y)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants