Skip to content

Add a new 'Export' page under Feedback.#3637

Merged
samhotchkiss merged 2 commits intomasterfrom
contact-form/move-export
Feb 17, 2017
Merged

Add a new 'Export' page under Feedback.#3637
samhotchkiss merged 2 commits intomasterfrom
contact-form/move-export

Conversation

@georgestephanis
Copy link
Copy Markdown
Contributor

This should help to make the 'Export' functionality more obvious.
As-is, it's an often missed feature, and I've seen people spend hours
trying to build workarounds, not realizing it was already there.

This should help to make the 'Export' functionality more obvious.
As-is, it's an often missed feature, and I've seen people spend hours
trying to build workarounds, not realizing it was already there.
@bph
Copy link
Copy Markdown

bph commented Apr 8, 2016

Great Idea! This will help adoption! Thank you!

@jeherve jeherve added the Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Apr 11, 2016
@jeherve jeherve added this to the 4.1 milestone Apr 11, 2016
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Apr 11, 2016

Is this PR ready for review, or is it still a work in progress?

Before it gets reviewed, it would probably be nice to make sure the submenu appears when the PollDaddy plugin is installed. It doesn't at the moment.

(Quick reminder: when PollDaddy is active, the Feedback menu changes a bit:

screen shot 2016-04-11 at 4 06 14 pm

@jeherve jeherve added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 11, 2016
@jeherve jeherve modified the milestones: 4.2, 4.1 Jun 17, 2016
@jeherve jeherve modified the milestones: 4.3, 4.2 Jul 6, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@samhotchkiss samhotchkiss modified the milestones: Not Currently Planned, 4.4 Nov 9, 2016
@georgestephanis georgestephanis self-assigned this Nov 9, 2016
@eliorivero
Copy link
Copy Markdown
Contributor

Needs a rebase.

@dereksmart
Copy link
Copy Markdown
Contributor

dereksmart commented Feb 13, 2017

The PollDaddy plugin issue seems like a separate one, and can be addressed as so. @georgestephanis Mind running this through a rebase?

@georgestephanis
Copy link
Copy Markdown
Contributor Author

@dereksmart Done.

@dereksmart dereksmart added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 13, 2017
@dereksmart
Copy link
Copy Markdown
Contributor

This works as expected, however was it ever considered to simply move the export to the top of the page?
screen shot 2017-02-13 at 3 22 06 pm

Though now that I'm looking at it, it's a bit annoying up there.

Anyway this code LGTM as-is.

@jeherve jeherve removed this from the Not Currently Planned milestone Feb 16, 2017
@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 16, 2017
@samhotchkiss samhotchkiss merged commit 8e994f8 into master Feb 17, 2017
@samhotchkiss samhotchkiss deleted the contact-form/move-export branch February 17, 2017 03:12
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 17, 2017
@jeherve jeherve added [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Feb 17, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Forms [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants