Skip to content

Use the sharing filters in e-mail too#6342

Merged
samhotchkiss merged 2 commits intomasterfrom
update/share-via-email-more-filters
Feb 10, 2017
Merged

Use the sharing filters in e-mail too#6342
samhotchkiss merged 2 commits intomasterfrom
update/share-via-email-more-filters

Conversation

@singerb
Copy link
Copy Markdown
Contributor

@singerb singerb commented Feb 9, 2017

Fixes #5989

Per the issue, the URL and title shared are filterable for the other sharing types, but not e-mail. This change makes sure to call the same functions when sharing via e-mail.

Test plan:

  • Have a server where e-mail sharing works and apply patch
  • Share a post via e-mail, verify it looks normal
  • Add sharing_permalink and sharing_title filters and share a post again; verify you get the new values

Fixes #5989

Per the issue, the URL and title shared are filterable for the other
sharing types, but not e-mail. This change makes sure to call the same
functions when sharing via e-mail.

Test plan:

- Have a server where e-mail sharing works and apply patch
- Share a post via e-mail, verify it looks normal
- Add `sharing_permalink` and `sharing_title` filters and share a post
again; verify you get the new values
Missed the other file from the first commit.
@singerb singerb added the [Status] Needs Review This PR is ready for review. label Feb 9, 2017
@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons [Pri] Normal Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 9, 2017
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, LGTM!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 10, 2017
@samhotchkiss samhotchkiss merged commit 4d148b9 into master Feb 10, 2017
@samhotchkiss samhotchkiss deleted the update/share-via-email-more-filters branch February 10, 2017 15:08
@samhotchkiss samhotchkiss added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 10, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons [Pri] Normal Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants