Widgets: use Photon to display image in Image Widget.#4220
Widgets: use Photon to display image in Image Widget.#4220samhotchkiss merged 3 commits intomasterfrom
Conversation
modules/widgets/image-widget.php
Outdated
| if ( '' != $instance['img_url'] ) { | ||
|
|
||
| $output = '<img src="' . esc_attr( $instance['img_url'] ) .'" '; | ||
| $output = '<img src="' . jetpack_photon_url( esc_attr( $instance['img_url'] ), array( |
There was a problem hiding this comment.
Shouldn't it be esc_url instead of esc_attr?
There was a problem hiding this comment.
@eliorivero Can you please update this pull request to use esc_url()
b1dbd87 to
c8825a4
Compare
…eck if it should open in a new browser tab only if there's a link.
|
I just tested it with an old image widget that was already active on my site, and for some reason
I can see
No problem when taking the same image and creating a new Image widget, though:
I wonder if we should add a check like here to cover old widgets like that? What do you think? |
|
Needs @eliorivero author reply before proceeding. |
|
Do we want to always use Photon for this widget or only when the Photon module is enabled? |
|
@kraftbj Based on the original request, only when the module is enabled. |
modules/widgets/image-widget.php
Outdated
| if ( '' != $instance['img_url'] ) { | ||
|
|
||
| $output = '<img src="' . esc_attr( $instance['img_url'] ) .'" '; | ||
| $output = '<img src="' . esc_url( jetpack_photon_url( $instance['img_url'], array( |
There was a problem hiding this comment.
Need to add ( method_exists( 'Jetpack', 'is_module_active' ) && Jetpack::is_module_active( 'photon' ) ) conditional.
There was a problem hiding this comment.
I added only Jetpack::is_module_active( 'photon' ). Note that in many widgets (like Follow Button) we call Jetpack::is_active() on widgets_init and only then the widget is registered so by the time of widget registration the Jetpack class (and its methods) exists.
|
@jeherve I can't reproduce the issue. Starting with master and Photon enabled, I added an Image widget an image URL and 400 x 225 like you have. Saved, checked in front end, all good. Switched to branch, checked in front end again, width and height were there. |
|
I'm afraid I can still experience an issue, but it now happens to new widgets, not existing ones. Try the following:
This doesn't happen with image widgets that were created before the branch was checked. Compare this image widget, added before to check out the branch:
And this image widget, added after checking out the branch:
Can you reproduce as well? |
|
I followed your steps and found that it only happens in my installation when Photon module is deactivated:
If it's active, the dimensions are properly set |
jeherve
left a comment
There was a problem hiding this comment.
I can still reproduce the problem, but the width and height parameters are then added if I edit the widget settings again to add something else, like a title. It seems to only happen when creating a widget and just pasting an image URL.
The problem is not related to this PR, so I think this is good to merge.
Change requested by Brandon has been addressed.
* Changelog: update stable tag and move changelog to changelog.txt Also remove old releases from readme.txt to keep the changelog tab short. * Changelog: add #5883 Also update the filter's docblock to match new version. * Changelog: add #5938 * Changelog: add #6298 * Changelog: add #3405 * Changelog: add #5941 * Changelog: add #6239 * Changelog: add #6281 * Changelog: add #6303 * Changelog: add #6018 * Changelog: add #6300 * Changelog: add #6296 * Changelog: add #6130 * Changelog: add #6292 * Readme: remove extra "on". * Changelog: add #6307 * Changelog: add #3297 * Changelog: add #6275 * Changelog: add #6321 * Changelog: add #6297 * Readme: update the support forum link anchor. Anchor changed when WordPress.org forums were updated to bbPress 2 * Readme: update list of a12s, it wasn't up to date anymore! * Changelog: add #6338 * Changelog: add #6337 * Changelog: add #6335 * Changelog: add #6333 * Testing List: first version of the 4.7 testing list. * Changelog: add #6332 * Changelog: add #6325 * Changelog: add #6326 * Changelog: add #6339 * Changelog: add #6342 * Changelog: add #6343 * Changelog: add #6346 * Changelog: add #6347 * Changelog: add #6279 * Changelog: add #6306 * Changelog: add #6312 * Changelog: add #6316 * Changelog: add #6171 * Changelog: add #6317 * Changelog: add #6246 * Changelog: add #6263 * Changelog: add #4220 * Changelog: add #5888 * Changelog: add #3406 * Changelog: add #3637 * Changelog: add #6320 * Changelog: add #5992 * Changelog: add #6322 * Changelog: add #6324 * Changelog: add #6352 * Changelog: add #6355 * Changelog: add #6360 * Changelog: add #6362 * Changelog: add #6369, #6382 * Changelog: add #6370 * Changelog: add #6375 * Changelog: add #6383 * Changelog: add #6384 * Changelog: add #6386 * Changelog: add #6395 * Changelog: add #6403 * Changelog: add #6406 * Changelog: add #6418 * Changelog: add #6419 * Changelog: add #6434 * Changelog: add #6446 * Changelog: add #6006 * Changelog: add #6096 * Changelog: add #6399 * Changelog: fix typo. @see #6331 (comment) * Changelog: add #6440 * Changelog: add #6443 * Changelog: add #6445 * Changelog: add #6463 * Changelog: add #6468 * Changelog: add #6471 * Changelog: add #6474 * Changelog: add #6480 * Changelog: add #6497 * Changelog: add #6499 * Changelog: add #6514 * Changelog: add #6267 * Changelog: add #5940 * Changelog: add #6492 * Changelog: add #5281 * Changelog: add #6327 * Changelog: add #6451 * Changelog: add #6525 * Changelog: add #6530
Fixes #4141
Changes proposed in this Pull Request:
Changelog
Extra Widgets: if Photon is available, use it to serve the image in the Image widget.